Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to the browser #1344

Closed
rauchg opened this issue Jan 5, 2017 · 6 comments
Closed

Improvements to the browser #1344

rauchg opened this issue Jan 5, 2017 · 6 comments

Comments

@rauchg
Copy link
Member

rauchg commented Jan 5, 2017

  • target=_blank links should open in a new full browser tab
  • cmd+click should open in a new full browser tab
  • cmd+R should refresh
  • there should be a subtle indicator of focus
  • hovering a link should render a chrome-like bottom-left link overlay
  • quitting the browser doesn't give focus back to the owner term
  • hovering the top portion of the screen could reveal a simple overlay toolbar

I think these are changes we might want to ship in our first core plugin hyperweb as opposed to bloating hyper.

Tagging @codetheory and @evilrabbit to start working through some designs

@stefanivic
Copy link
Contributor

@rauchg we should also focus on getting the browser to work on Linux and Windows, as it's not working at the moment. :D

@ppot
Copy link
Contributor

ppot commented Jan 25, 2017

@stefanivic Can you explain why it's not working?

@stefanivic
Copy link
Contributor

@ppot on Windows #1403 on Linux you just get a white screen.

@therealplato
Copy link

I ran screen and then http://isup.me.

I can't figure out how to close the browser and return to my terminal prompt / screen session.

I tried cmd-w, ctrl-w, esc, backspace expecting one of these to work. I can close the terminal tab, but reattaching screen -x brings the browser window back.

@stefanivic
Copy link
Contributor

@therealplato try ctrl+shift+c

@therealplato
Copy link

thanks. figured out the behavior. 1.1.0.1408 on OSX Sierra:

Given I have typed http://isup.me at the hyper prompt and pressed enter and see the browser:
When I press control-C
Then I expect the browser to quit
But actually it stays open

Given I have typed http://isup.me at the hyper prompt and pressed enter and see the browser:
When I click the browser, and then press control-C
Then the browser quits, as expected

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants