Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed zoom keymaps for windowsOS, fixes #2448 #2489

Merged
merged 3 commits into from Apr 24, 2018

Conversation

EdgarACarneiro
Copy link
Contributor

This PR fixes #2448, and is related to #2447 #1496.

This fix is related to a mousetrap issue.

Copy link
Contributor

@albinekb albinekb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I have not tested on windows nor linux, but looks alright after reading the mousetrap issue.

@EdgarACarneiro EdgarACarneiro mentioned this pull request Dec 8, 2017
@Stanzilla Stanzilla added the 🎨 Type: Enhancement Issue or PR is an enhancement request/proposal for Hyper label Apr 23, 2018
@Stanzilla Stanzilla requested a review from chabou April 24, 2018 12:33
@Stanzilla
Copy link
Collaborator

Tested on Windows, works perfectly!

@chabou chabou merged commit d1eb020 into vercel:canary Apr 24, 2018
chabou pushed a commit that referenced this pull request Dec 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 Type: Enhancement Issue or PR is an enhancement request/proposal for Hyper
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Zoom In Zoom Out KeyMaps not working
5 participants