Fix ncc'd version of terser not being used by terser webpack plugin (#…

…12252)
vercel · Apr 28, 2020 · af33ebc · af33ebc
1 parent f080931
commit af33ebc
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 5 deletions.
diff --git a/packages/next/compiled/terser-webpack-plugin/worker.js b/packages/next/compiled/terser-webpack-plugin/worker.js
@@ -2,7 +2,7 @@
 
 const {
   minify: terserMinify
-} = require('terser');
+} = require("next/dist/compiled/terser");
 
 const buildTerserOptions = ({
   ecma,

diff --git a/packages/next/taskfile-ncc.js b/packages/next/taskfile-ncc.js
@@ -14,13 +14,26 @@ module.exports = function(task) {
       minify: true,
       ...options,
     }).then(({ code, assets }) => {
-      Object.keys(assets).forEach(key =>
+      Object.keys(assets).forEach(key => {
+        let data = assets[key].source
+
+        if (join(file.dir, key).endsWith('terser-webpack-plugin/worker.js')) {
+          data = Buffer.from(
+            data
+              .toString()
+              .replace(
+                `require('terser')`,
+                `require("${options.externals['terser']}")`
+              )
+          )
+        }
+
         this._.files.push({
-          dir: join(file.dir, dirname(key)),
+          data,
           base: basename(key),
-          data: assets[key].source,
+          dir: join(file.dir, dirname(key)),
         })
-      )
+      })
 
       if (options && options.packageName) {
         writePackageManifest.call(this, options.packageName, file.base)