Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(auth): add with-iron-session to the alternatives list #11903

Merged
merged 1 commit into from
Apr 15, 2020
Merged

docs(auth): add with-iron-session to the alternatives list #11903

merged 1 commit into from
Apr 15, 2020

Conversation

vvo
Copy link
Member

@vvo vvo commented Apr 15, 2020

Following #11865 (comment)

@vvo vvo requested review from lfades and Timer as code owners April 15, 2020 03:57
@ijjk
Copy link
Member

ijjk commented Apr 15, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General
zeit/next.js canary vvo/next.js patch-2 Change
buildDuration 10.9s 11.3s ⚠️ +372ms
nodeModulesSize 55.5 MB 55.5 MB ✓
Page Load Tests Overall increase ✓
zeit/next.js canary vvo/next.js patch-2 Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.234 2.273 ⚠️ +0.04
/ avg req/sec 1119.14 1099.81 -19.33
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.318 1.263 -0.06
/error-in-render avg req/sec 1896.9 1979.43 ⚠️ +82.53
Client Bundles (main, webpack, commons)
zeit/next.js canary vvo/next.js patch-2 Change
main-HASH.js gzip 6.24 kB 6.24 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..93a0.js gzip 10.3 kB 10.3 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 56.4 kB 56.4 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary vvo/next.js patch-2 Change
main-HASH.module.js gzip 4.77 kB 4.77 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.84 kB 6.84 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 51.5 kB 51.5 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary vvo/next.js patch-2 Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary vvo/next.js patch-2 Change
_app.js gzip 1.24 kB 1.24 kB ✓
_error.js gzip 3.15 kB 3.15 kB ✓
hooks.js gzip 664 B 664 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.06 kB 2.06 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.88 kB 7.88 kB ✓
Client Pages Modern
zeit/next.js canary vvo/next.js patch-2 Change
_app.module.js gzip 594 B 594 B ✓
_error.module.js gzip 2.08 kB 2.08 kB ✓
hooks.module.js gzip 370 B 370 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 1.51 kB 1.51 kB ✓
routerDirect..dule.js gzip 271 B 271 B ✓
withRouter.m..dule.js gzip 270 B 270 B ✓
Overall change 5.3 kB 5.3 kB ✓
Client Build Manifests
zeit/next.js canary vvo/next.js patch-2 Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes
zeit/next.js canary vvo/next.js patch-2 Change
index.html gzip 925 B 925 B ✓
link.html gzip 935 B 935 B ✓
withRouter.html gzip 922 B 922 B ✓
Overall change 2.78 kB 2.78 kB ✓
Serverless Mode
General
zeit/next.js canary vvo/next.js patch-2 Change
buildDuration 11.8s 11.6s -211ms
nodeModulesSize 55.5 MB 55.5 MB ✓
Client Bundles (main, webpack, commons)
zeit/next.js canary vvo/next.js patch-2 Change
main-HASH.js gzip 6.24 kB 6.24 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..93a0.js gzip 10.3 kB 10.3 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 56.4 kB 56.4 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary vvo/next.js patch-2 Change
main-HASH.module.js gzip 4.77 kB 4.77 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.84 kB 6.84 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 51.5 kB 51.5 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary vvo/next.js patch-2 Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary vvo/next.js patch-2 Change
_app.js gzip 1.24 kB 1.24 kB ✓
_error.js gzip 3.15 kB 3.15 kB ✓
hooks.js gzip 664 B 664 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.06 kB 2.06 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.88 kB 7.88 kB ✓
Client Pages Modern
zeit/next.js canary vvo/next.js patch-2 Change
_app.module.js gzip 594 B 594 B ✓
_error.module.js gzip 2.08 kB 2.08 kB ✓
hooks.module.js gzip 370 B 370 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 1.51 kB 1.51 kB ✓
routerDirect..dule.js gzip 271 B 271 B ✓
withRouter.m..dule.js gzip 270 B 270 B ✓
Overall change 5.3 kB 5.3 kB ✓
Client Build Manifests
zeit/next.js canary vvo/next.js patch-2 Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles
zeit/next.js canary vvo/next.js patch-2 Change
_error.js 557 kB 557 kB ✓
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.81 kB 3.81 kB ✓
index.js 557 kB 557 kB ✓
link.js 594 kB 594 kB ✓
routerDirect.js 586 kB 586 kB ✓
withRouter.js 586 kB 586 kB ✓
Overall change 2.89 MB 2.89 MB ✓

Timer
Timer approved these changes Apr 15, 2020
View reviewed changes
Copy link
Member

@Timer Timer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Timer Timer merged commit 90ffdcc into vercel:canary Apr 15, 2020
@Timer Timer added this to the 9.3.6 milestone Apr 15, 2020
@vvo vvo deleted the patch-2 branch April 15, 2020 09:51
This was referenced May 1, 2020
Closed
Closed
@vercel vercel locked as resolved and limited conversation to collaborators Jan 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Timer Timer Timer approved these changes

@lfades lfades Awaiting requested review from lfades

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
9.3.6
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vvo @ijjk @Timer