Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 'user undefined' error with ssr profile in auth0 example #11934

Merged
merged 2 commits into from
May 2, 2020
Merged

Fix 'user undefined' error with ssr profile in auth0 example #11934

merged 2 commits into from
May 2, 2020

Conversation

makezi
Copy link
Contributor

@makezi makezi commented Apr 16, 2020

When a user is not logged in and attempts to navigate to the SSR profile route under /advanced/ssr-profile, they're treated with a TypeError of user being undefined.

This fix replaces the destructuring of the user from a non-existent session - it instead checks for an existing session AND user within session.

Screen Shot 2020-04-16 at 3 27 12 pm

@ijjk
Copy link
Member

ijjk commented Apr 16, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
zeit/next.js canary makezi/next.js fix-auth0-example Change
buildDuration 12.8s 13.2s ⚠️ +471ms
nodeModulesSize 55.5 MB 55.5 MB ✓
Page Load Tests Overall decrease ⚠️
zeit/next.js canary makezi/next.js fix-auth0-example Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.107 2.181 ⚠️ +0.07
/ avg req/sec 1186.61 1146.24 -40.37
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.185 1.265 ⚠️ +0.08
/error-in-render avg req/sec 2110.22 1976.81 -133.41
Client Bundles (main, webpack, commons)
zeit/next.js canary makezi/next.js fix-auth0-example Change
main-HASH.js gzip 6.25 kB 6.25 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..5e5e.js gzip 10.3 kB 10.3 kB ✓
framework.a1..NSE.txt gzip 220 B 220 B ✓
framework.a1..NSE.txt gzip 220 B 220 B ✓
framework.HASH.js gzip 39 kB 39 kB ✓
Overall change 56.7 kB 56.7 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary makezi/next.js fix-auth0-example Change
main-HASH.module.js gzip 4.79 kB 4.79 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.85 kB 6.85 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
Overall change 51.4 kB 51.4 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary makezi/next.js fix-auth0-example Change
polyfills-HASH.js gzip 26.2 kB 26.2 kB ✓
Overall change 26.2 kB 26.2 kB ✓
Client Pages
zeit/next.js canary makezi/next.js fix-auth0-example Change
_app.js gzip 1.24 kB 1.24 kB ✓
_error.js gzip 3.12 kB 3.12 kB ✓
hooks.js gzip 664 B 664 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.06 kB 2.06 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.86 kB 7.86 kB ✓
Client Pages Modern
zeit/next.js canary makezi/next.js fix-auth0-example Change
_app.module.js gzip 602 B 602 B ✓
_error.module.js gzip 2.09 kB 2.09 kB ✓
hooks.module.js gzip 383 B 383 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js gzip 1.52 kB 1.52 kB ✓
routerDirect..dule.js gzip 281 B 281 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 5.38 kB 5.38 kB ✓
Client Build Manifests
zeit/next.js canary makezi/next.js fix-auth0-example Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes
zeit/next.js canary makezi/next.js fix-auth0-example Change
index.html gzip 926 B 926 B ✓
link.html gzip 937 B 937 B ✓
withRouter.html gzip 924 B 924 B ✓
Overall change 2.79 kB 2.79 kB ✓
Serverless Mode
General
zeit/next.js canary makezi/next.js fix-auth0-example Change
buildDuration 13.7s 13.4s -360ms
nodeModulesSize 55.5 MB 55.5 MB ✓
Client Bundles (main, webpack, commons)
zeit/next.js canary makezi/next.js fix-auth0-example Change
main-HASH.js gzip 6.25 kB 6.25 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..5e5e.js gzip 10.3 kB 10.3 kB ✓
framework.a1..NSE.txt gzip 220 B 220 B ✓
framework.a1..NSE.txt gzip 220 B 220 B ✓
framework.HASH.js gzip 39 kB 39 kB ✓
Overall change 56.7 kB 56.7 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary makezi/next.js fix-auth0-example Change
main-HASH.module.js gzip 4.79 kB 4.79 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.85 kB 6.85 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
Overall change 51.4 kB 51.4 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary makezi/next.js fix-auth0-example Change
polyfills-HASH.js gzip 26.2 kB 26.2 kB ✓
Overall change 26.2 kB 26.2 kB ✓
Client Pages
zeit/next.js canary makezi/next.js fix-auth0-example Change
_app.js gzip 1.24 kB 1.24 kB ✓
_error.js gzip 3.12 kB 3.12 kB ✓
hooks.js gzip 664 B 664 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.06 kB 2.06 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.86 kB 7.86 kB ✓
Client Pages Modern
zeit/next.js canary makezi/next.js fix-auth0-example Change
_app.module.js gzip 602 B 602 B ✓
_error.module.js gzip 2.09 kB 2.09 kB ✓
hooks.module.js gzip 383 B 383 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js gzip 1.52 kB 1.52 kB ✓
routerDirect..dule.js gzip 281 B 281 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 5.38 kB 5.38 kB ✓
Client Build Manifests
zeit/next.js canary makezi/next.js fix-auth0-example Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles
zeit/next.js canary makezi/next.js fix-auth0-example Change
_error.js 557 kB 557 kB ✓
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.81 kB 3.81 kB ✓
index.js 557 kB 557 kB ✓
link.js 594 kB 594 kB ✓
routerDirect.js 586 kB 586 kB ✓
withRouter.js 586 kB 586 kB ✓
Overall change 2.89 MB 2.89 MB ✓

@ijjk
Copy link
Member

ijjk commented Apr 16, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
zeit/next.js canary makezi/next.js fix-auth0-example Change
buildDuration 12.5s 12.6s ⚠️ +115ms
nodeModulesSize 55.5 MB 55.5 MB ✓
Page Load Tests Overall decrease ⚠️
zeit/next.js canary makezi/next.js fix-auth0-example Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.169 2.155 -0.01
/ avg req/sec 1152.58 1160.3 ⚠️ +7.72
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.184 1.205 ⚠️ +0.02
/error-in-render avg req/sec 2111.07 2073.86 -37.21
Client Bundles (main, webpack, commons)
zeit/next.js canary makezi/next.js fix-auth0-example Change
main-HASH.js gzip 6.25 kB 6.25 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..5e5e.js gzip 10.3 kB 10.3 kB ✓
framework.a1..NSE.txt gzip 220 B 220 B ✓
framework.a1..NSE.txt gzip 220 B 220 B ✓
framework.HASH.js gzip 39 kB 39 kB ✓
Overall change 56.7 kB 56.7 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary makezi/next.js fix-auth0-example Change
main-HASH.module.js gzip 4.79 kB 4.79 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.85 kB 6.85 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
Overall change 51.4 kB 51.4 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary makezi/next.js fix-auth0-example Change
polyfills-HASH.js gzip 26.2 kB 26.2 kB ✓
Overall change 26.2 kB 26.2 kB ✓
Client Pages
zeit/next.js canary makezi/next.js fix-auth0-example Change
_app.js gzip 1.24 kB 1.24 kB ✓
_error.js gzip 3.12 kB 3.12 kB ✓
hooks.js gzip 664 B 664 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.06 kB 2.06 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.86 kB 7.86 kB ✓
Client Pages Modern
zeit/next.js canary makezi/next.js fix-auth0-example Change
_app.module.js gzip 602 B 602 B ✓
_error.module.js gzip 2.09 kB 2.09 kB ✓
hooks.module.js gzip 383 B 383 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js gzip 1.52 kB 1.52 kB ✓
routerDirect..dule.js gzip 281 B 281 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 5.38 kB 5.38 kB ✓
Client Build Manifests
zeit/next.js canary makezi/next.js fix-auth0-example Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes
zeit/next.js canary makezi/next.js fix-auth0-example Change
index.html gzip 926 B 926 B ✓
link.html gzip 937 B 937 B ✓
withRouter.html gzip 924 B 924 B ✓
Overall change 2.79 kB 2.79 kB ✓
Serverless Mode
General
zeit/next.js canary makezi/next.js fix-auth0-example Change
buildDuration 13s 12.2s -800ms
nodeModulesSize 55.5 MB 55.5 MB ✓
Client Bundles (main, webpack, commons)
zeit/next.js canary makezi/next.js fix-auth0-example Change
main-HASH.js gzip 6.25 kB 6.25 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..5e5e.js gzip 10.3 kB 10.3 kB ✓
framework.a1..NSE.txt gzip 220 B 220 B ✓
framework.a1..NSE.txt gzip 220 B 220 B ✓
framework.HASH.js gzip 39 kB 39 kB ✓
Overall change 56.7 kB 56.7 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary makezi/next.js fix-auth0-example Change
main-HASH.module.js gzip 4.79 kB 4.79 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.85 kB 6.85 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
Overall change 51.4 kB 51.4 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary makezi/next.js fix-auth0-example Change
polyfills-HASH.js gzip 26.2 kB 26.2 kB ✓
Overall change 26.2 kB 26.2 kB ✓
Client Pages
zeit/next.js canary makezi/next.js fix-auth0-example Change
_app.js gzip 1.24 kB 1.24 kB ✓
_error.js gzip 3.12 kB 3.12 kB ✓
hooks.js gzip 664 B 664 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.06 kB 2.06 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.86 kB 7.86 kB ✓
Client Pages Modern
zeit/next.js canary makezi/next.js fix-auth0-example Change
_app.module.js gzip 602 B 602 B ✓
_error.module.js gzip 2.09 kB 2.09 kB ✓
hooks.module.js gzip 383 B 383 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js gzip 1.52 kB 1.52 kB ✓
routerDirect..dule.js gzip 281 B 281 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 5.38 kB 5.38 kB ✓
Client Build Manifests
zeit/next.js canary makezi/next.js fix-auth0-example Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles
zeit/next.js canary makezi/next.js fix-auth0-example Change
_error.js 557 kB 557 kB ✓
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.81 kB 3.81 kB ✓
index.js 557 kB 557 kB ✓
link.js 594 kB 594 kB ✓
routerDirect.js 586 kB 586 kB ✓
withRouter.js 586 kB 586 kB ✓
Overall change 2.89 MB 2.89 MB ✓

@ijjk
Copy link
Member

ijjk commented Apr 16, 2020

Failing test suites

test/integration/basic/test/index.test.js

  • Basic Features > Error Recovery > should recover from errors in getInitialProps in client
  • Basic Features > Error Recovery > should recover after an error reported via SSR
Expand output

● Basic Features › Error Recovery › should recover from errors in getInitialProps in client

TIMED OUT CHECK FOR IFRAME

  388 |     }
  389 |     console.error('TIMED OUT CHECK FOR IFRAME')
> 390 |     throw new Error('TIMED OUT CHECK FOR IFRAME')
      |           ^
  391 |   }, 1000 * 30)
  392 |   while (!found) {
  393 |     try {

  at Timeout._onTimeout (lib/next-test-utils.js:390:11)

● Basic Features › Error Recovery › should recover after an error reported via SSR

TIMED OUT CHECK FOR IFRAME

  388 |     }
  389 |     console.error('TIMED OUT CHECK FOR IFRAME')
> 390 |     throw new Error('TIMED OUT CHECK FOR IFRAME')
      |           ^
  391 |   }, 1000 * 30)
  392 |   while (!found) {
  393 |     try {

  at Timeout._onTimeout (lib/next-test-utils.js:390:11)

@Timer Timer added this to the 9.3.7 milestone May 2, 2020
@Timer Timer added the examples Issue/PR related to examples label May 2, 2020
@Timer Timer merged commit a2b9f24 into vercel:canary May 2, 2020
@Timer Timer modified the milestones: 9.3.7, 9.4 May 11, 2020
rokinsky pushed a commit to rokinsky/next.js that referenced this pull request Jul 11, 2020
@rokinsky
Fix 'user undefined' error with ssr profile in auth0 example (vercel#…
32c4de5 
…11934)
@vercel vercel locked as resolved and limited conversation to collaborators Jan 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Timer Timer Timer approved these changes

@lfades lfades Awaiting requested review from lfades

Assignees
No one assigned
Labels
examples Issue/PR related to examples
Projects
None yet
Milestone
9.4
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@makezi @ijjk @Timer