Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated with-firebase-authentication to fix errors #12204

Merged
merged 1 commit into from
May 2, 2020
Merged

Updated with-firebase-authentication to fix errors #12204

merged 1 commit into from
May 2, 2020

Conversation

kohchihao
Copy link
Contributor

Related to #12139

In this PR

  • Fixed error where serializing .user is causing an undefined error.
  • Updated to use firestore collection methods instead of realtime database methods.

@ijjk
Copy link
Member

ijjk commented Apr 26, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
zeit/next.js canary kohchihao/next.js fix-with-firebase-authentication Change
buildDuration 10.7s 10.7s ⚠️ +28ms
nodeModulesSize 55.3 MB 55.3 MB ✓
Page Load Tests Overall decrease ⚠️
zeit/next.js canary kohchihao/next.js fix-with-firebase-authentication Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.867 1.754 -0.11
/ avg req/sec 1338.86 1425.18 ⚠️ +86.32
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 0.864 0.914 ⚠️ +0.05
/error-in-render avg req/sec 2892.13 2736.37 -155.76
Client Bundles (main, webpack, commons)
zeit/next.js canary kohchihao/next.js fix-with-firebase-authentication Change
main-HASH.js gzip 6.25 kB 6.25 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..45d6.js gzip 10.3 kB 10.3 kB ✓
framework.a1..NSE.txt gzip 220 B 220 B ✓
framework.a1..NSE.txt gzip 220 B 220 B ✓
framework.HASH.js gzip 39 kB 39 kB ✓
Overall change 56.7 kB 56.7 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary kohchihao/next.js fix-with-firebase-authentication Change
main-HASH.module.js gzip 4.79 kB 4.79 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.87 kB 6.87 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
Overall change 51.4 kB 51.4 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary kohchihao/next.js fix-with-firebase-authentication Change
polyfills-HASH.js gzip 26.2 kB 26.2 kB ✓
Overall change 26.2 kB 26.2 kB ✓
Client Pages
zeit/next.js canary kohchihao/next.js fix-with-firebase-authentication Change
_app.js gzip 1.23 kB 1.23 kB ✓
_error.js gzip 3.12 kB 3.12 kB ✓
hooks.js gzip 663 B 663 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.06 kB 2.06 kB ✓
routerDirect.js gzip 280 B 280 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.85 kB 7.85 kB ✓
Client Pages Modern
zeit/next.js canary kohchihao/next.js fix-with-firebase-authentication Change
_app.module.js gzip 598 B 598 B ✓
_error.module.js gzip 2.09 kB 2.09 kB ✓
hooks.module.js gzip 383 B 383 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js gzip 1.52 kB 1.52 kB ✓
routerDirect..dule.js gzip 279 B 279 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 5.37 kB 5.37 kB ✓
Client Build Manifests
zeit/next.js canary kohchihao/next.js fix-with-firebase-authentication Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes
zeit/next.js canary kohchihao/next.js fix-with-firebase-authentication Change
index.html gzip 929 B 929 B ✓
link.html gzip 939 B 939 B ✓
withRouter.html gzip 926 B 926 B ✓
Overall change 2.79 kB 2.79 kB ✓
Serverless Mode
General
zeit/next.js canary kohchihao/next.js fix-with-firebase-authentication Change
buildDuration 11.3s 11.3s ⚠️ +48ms
nodeModulesSize 55.3 MB 55.3 MB ✓
Client Bundles (main, webpack, commons)
zeit/next.js canary kohchihao/next.js fix-with-firebase-authentication Change
main-HASH.js gzip 6.25 kB 6.25 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..45d6.js gzip 10.3 kB 10.3 kB ✓
framework.a1..NSE.txt gzip 220 B 220 B ✓
framework.a1..NSE.txt gzip 220 B 220 B ✓
framework.HASH.js gzip 39 kB 39 kB ✓
Overall change 56.7 kB 56.7 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary kohchihao/next.js fix-with-firebase-authentication Change
main-HASH.module.js gzip 4.79 kB 4.79 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.87 kB 6.87 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
Overall change 51.4 kB 51.4 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary kohchihao/next.js fix-with-firebase-authentication Change
polyfills-HASH.js gzip 26.2 kB 26.2 kB ✓
Overall change 26.2 kB 26.2 kB ✓
Client Pages
zeit/next.js canary kohchihao/next.js fix-with-firebase-authentication Change
_app.js gzip 1.23 kB 1.23 kB ✓
_error.js gzip 3.12 kB 3.12 kB ✓
hooks.js gzip 663 B 663 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.06 kB 2.06 kB ✓
routerDirect.js gzip 280 B 280 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.85 kB 7.85 kB ✓
Client Pages Modern
zeit/next.js canary kohchihao/next.js fix-with-firebase-authentication Change
_app.module.js gzip 598 B 598 B ✓
_error.module.js gzip 2.09 kB 2.09 kB ✓
hooks.module.js gzip 383 B 383 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js gzip 1.52 kB 1.52 kB ✓
routerDirect..dule.js gzip 279 B 279 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 5.37 kB 5.37 kB ✓
Client Build Manifests
zeit/next.js canary kohchihao/next.js fix-with-firebase-authentication Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles
zeit/next.js canary kohchihao/next.js fix-with-firebase-authentication Change
_error.js 558 kB 558 kB ✓
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.81 kB 3.81 kB ✓
index.js 558 kB 558 kB ✓
link.js 595 kB 595 kB ✓
routerDirect.js 587 kB 587 kB ✓
withRouter.js 587 kB 587 kB ✓
Overall change 2.89 MB 2.89 MB ✓

@kohchihao
Fix error serializing user
6de99ca 
Fix pages/index.js styles
@kohchihao kohchihao force-pushed the fix-with-firebase-authentication branch from ae152a8 to 6de99ca Compare April 26, 2020 05:58
@ijjk
Copy link
Member

ijjk commented Apr 26, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General
zeit/next.js canary kohchihao/next.js fix-with-firebase-authentication Change
buildDuration 13.3s 13.1s -154ms
nodeModulesSize 55.3 MB 55.3 MB ✓
Page Load Tests Overall increase ✓
zeit/next.js canary kohchihao/next.js fix-with-firebase-authentication Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.287 2.271 -0.02
/ avg req/sec 1093.2 1100.83 ⚠️ +7.63
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.357 1.341 -0.02
/error-in-render avg req/sec 1842.77 1864.46 ⚠️ +21.69
Client Bundles (main, webpack, commons)
zeit/next.js canary kohchihao/next.js fix-with-firebase-authentication Change
main-HASH.js gzip 6.25 kB 6.25 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..45d6.js gzip 10.3 kB 10.3 kB ✓
framework.a1..NSE.txt gzip 220 B 220 B ✓
framework.a1..NSE.txt gzip 220 B 220 B ✓
framework.HASH.js gzip 39 kB 39 kB ✓
Overall change 56.7 kB 56.7 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary kohchihao/next.js fix-with-firebase-authentication Change
main-HASH.module.js gzip 4.79 kB 4.79 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.87 kB 6.87 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
Overall change 51.4 kB 51.4 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary kohchihao/next.js fix-with-firebase-authentication Change
polyfills-HASH.js gzip 26.2 kB 26.2 kB ✓
Overall change 26.2 kB 26.2 kB ✓
Client Pages
zeit/next.js canary kohchihao/next.js fix-with-firebase-authentication Change
_app.js gzip 1.23 kB 1.23 kB ✓
_error.js gzip 3.12 kB 3.12 kB ✓
hooks.js gzip 663 B 663 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.06 kB 2.06 kB ✓
routerDirect.js gzip 280 B 280 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.85 kB 7.85 kB ✓
Client Pages Modern
zeit/next.js canary kohchihao/next.js fix-with-firebase-authentication Change
_app.module.js gzip 598 B 598 B ✓
_error.module.js gzip 2.09 kB 2.09 kB ✓
hooks.module.js gzip 383 B 383 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js gzip 1.52 kB 1.52 kB ✓
routerDirect..dule.js gzip 279 B 279 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 5.37 kB 5.37 kB ✓
Client Build Manifests
zeit/next.js canary kohchihao/next.js fix-with-firebase-authentication Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes
zeit/next.js canary kohchihao/next.js fix-with-firebase-authentication Change
index.html gzip 929 B 929 B ✓
link.html gzip 939 B 939 B ✓
withRouter.html gzip 926 B 926 B ✓
Overall change 2.79 kB 2.79 kB ✓
Serverless Mode
General
zeit/next.js canary kohchihao/next.js fix-with-firebase-authentication Change
buildDuration 14.1s 14s -42ms
nodeModulesSize 55.3 MB 55.3 MB ✓
Client Bundles (main, webpack, commons)
zeit/next.js canary kohchihao/next.js fix-with-firebase-authentication Change
main-HASH.js gzip 6.25 kB 6.25 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..45d6.js gzip 10.3 kB 10.3 kB ✓
framework.a1..NSE.txt gzip 220 B 220 B ✓
framework.a1..NSE.txt gzip 220 B 220 B ✓
framework.HASH.js gzip 39 kB 39 kB ✓
Overall change 56.7 kB 56.7 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary kohchihao/next.js fix-with-firebase-authentication Change
main-HASH.module.js gzip 4.79 kB 4.79 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.87 kB 6.87 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
Overall change 51.4 kB 51.4 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary kohchihao/next.js fix-with-firebase-authentication Change
polyfills-HASH.js gzip 26.2 kB 26.2 kB ✓
Overall change 26.2 kB 26.2 kB ✓
Client Pages
zeit/next.js canary kohchihao/next.js fix-with-firebase-authentication Change
_app.js gzip 1.23 kB 1.23 kB ✓
_error.js gzip 3.12 kB 3.12 kB ✓
hooks.js gzip 663 B 663 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.06 kB 2.06 kB ✓
routerDirect.js gzip 280 B 280 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.85 kB 7.85 kB ✓
Client Pages Modern
zeit/next.js canary kohchihao/next.js fix-with-firebase-authentication Change
_app.module.js gzip 598 B 598 B ✓
_error.module.js gzip 2.09 kB 2.09 kB ✓
hooks.module.js gzip 383 B 383 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js gzip 1.52 kB 1.52 kB ✓
routerDirect..dule.js gzip 279 B 279 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 5.37 kB 5.37 kB ✓
Client Build Manifests
zeit/next.js canary kohchihao/next.js fix-with-firebase-authentication Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles
zeit/next.js canary kohchihao/next.js fix-with-firebase-authentication Change
_error.js 558 kB 558 kB ✓
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.81 kB 3.81 kB ✓
index.js 558 kB 558 kB ✓
link.js 595 kB 595 kB ✓
routerDirect.js 587 kB 587 kB ✓
withRouter.js 587 kB 587 kB ✓
Overall change 2.89 MB 2.89 MB ✓

@Timer Timer added the examples Issue/PR related to examples label May 2, 2020
@Timer Timer added this to the 9.3.7 milestone May 2, 2020
@Timer Timer merged commit 6a8aef7 into vercel:canary May 2, 2020
@Timer Timer modified the milestones: 9.3.7, 9.4 May 11, 2020
@leerob leerob mentioned this pull request May 13, 2020
Closed
rokinsky pushed a commit to rokinsky/next.js that referenced this pull request Jul 11, 2020
@kohchihao @rokinsky
Updated with-firebase-authentication to fix errors (vercel#12204)
d52d6a9
@vercel vercel locked as resolved and limited conversation to collaborators Jan 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Timer Timer Timer approved these changes

@lfades lfades Awaiting requested review from lfades

Assignees
No one assigned
Labels
examples Issue/PR related to examples
Projects
None yet
Milestone
9.4
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kohchihao @ijjk @Timer