Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[example-with-fela] CSS imports compatibility #12237

Merged
merged 5 commits into from
May 2, 2020
Merged

Conversation

robinweser
Copy link
Contributor

This PR updates the Fela example adding CSS imports compatibility (style nodes order etc.)
It also bumps all fela versions to latest making sure we always get the newest versions.

@ijjk
Copy link
Member

ijjk commented Apr 27, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General
zeit/next.js canary robinweser/next.js patch-1 Change
buildDuration 11.7s 12.2s ⚠️ +478ms
nodeModulesSize 55.2 MB 55.2 MB
Page Load Tests Overall increase ✓
zeit/next.js canary robinweser/next.js patch-1 Change
/ failed reqs 0 0
/ total time (seconds) 1.993 1.967 -0.03
/ avg req/sec 1254.36 1270.68 ⚠️ +16.32
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 0.995 0.985 -0.01
/error-in-render avg req/sec 2513.51 2537.24 ⚠️ +23.73
Client Bundles (main, webpack, commons)
zeit/next.js canary robinweser/next.js patch-1 Change
main-HASH.js gzip 6.27 kB 6.27 kB
webpack-HASH.js gzip 746 B 746 B
de003c3a9d30..ac5e.js gzip 10.3 kB 10.3 kB
framework.a1..NSE.txt gzip 220 B 220 B
framework.a1..NSE.txt gzip 220 B 220 B
framework.HASH.js gzip 39 kB 39 kB
Overall change 56.8 kB 56.8 kB
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary robinweser/next.js patch-1 Change
main-HASH.module.js gzip 4.82 kB 4.82 kB
webpack-HASH..dule.js gzip 746 B 746 B
de003c3a9d30..dule.js gzip 6.88 kB 6.88 kB
framework.HA..dule.js gzip 39 kB 39 kB
Overall change 51.5 kB 51.5 kB
Legacy Client Bundles (polyfills)
zeit/next.js canary robinweser/next.js patch-1 Change
polyfills-HASH.js gzip 26.2 kB 26.2 kB
Overall change 26.2 kB 26.2 kB
Client Pages
zeit/next.js canary robinweser/next.js patch-1 Change
_app.js gzip 1.23 kB 1.23 kB
_error.js gzip 3.12 kB 3.12 kB
hooks.js gzip 663 B 663 B
index.js gzip 222 B 222 B
link.js gzip 2.06 kB 2.06 kB
routerDirect.js gzip 280 B 280 B
withRouter.js gzip 278 B 278 B
Overall change 7.85 kB 7.85 kB
Client Pages Modern
zeit/next.js canary robinweser/next.js patch-1 Change
_app.module.js gzip 598 B 598 B
_error.module.js gzip 2.09 kB 2.09 kB
hooks.module.js gzip 383 B 383 B
index.module.js gzip 223 B 223 B
link.module.js gzip 1.52 kB 1.52 kB
routerDirect..dule.js gzip 279 B 279 B
withRouter.m..dule.js gzip 278 B 278 B
Overall change 5.37 kB 5.37 kB
Client Build Manifests
zeit/next.js canary robinweser/next.js patch-1 Change
_buildManifest.js gzip 61 B 61 B
_buildManife..dule.js gzip 61 B 61 B
Overall change 122 B 122 B
Rendered Page Sizes
zeit/next.js canary robinweser/next.js patch-1 Change
index.html gzip 927 B 927 B
link.html gzip 937 B 937 B
withRouter.html gzip 925 B 925 B
Overall change 2.79 kB 2.79 kB

Serverless Mode
General
zeit/next.js canary robinweser/next.js patch-1 Change
buildDuration 12.6s 12.4s -119ms
nodeModulesSize 55.2 MB 55.2 MB
Client Bundles (main, webpack, commons)
zeit/next.js canary robinweser/next.js patch-1 Change
main-HASH.js gzip 6.27 kB 6.27 kB
webpack-HASH.js gzip 746 B 746 B
de003c3a9d30..ac5e.js gzip 10.3 kB 10.3 kB
framework.a1..NSE.txt gzip 220 B 220 B
framework.a1..NSE.txt gzip 220 B 220 B
framework.HASH.js gzip 39 kB 39 kB
Overall change 56.8 kB 56.8 kB
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary robinweser/next.js patch-1 Change
main-HASH.module.js gzip 4.82 kB 4.82 kB
webpack-HASH..dule.js gzip 746 B 746 B
de003c3a9d30..dule.js gzip 6.88 kB 6.88 kB
framework.HA..dule.js gzip 39 kB 39 kB
Overall change 51.5 kB 51.5 kB
Legacy Client Bundles (polyfills)
zeit/next.js canary robinweser/next.js patch-1 Change
polyfills-HASH.js gzip 26.2 kB 26.2 kB
Overall change 26.2 kB 26.2 kB
Client Pages
zeit/next.js canary robinweser/next.js patch-1 Change
_app.js gzip 1.23 kB 1.23 kB
_error.js gzip 3.12 kB 3.12 kB
hooks.js gzip 663 B 663 B
index.js gzip 222 B 222 B
link.js gzip 2.06 kB 2.06 kB
routerDirect.js gzip 280 B 280 B
withRouter.js gzip 278 B 278 B
Overall change 7.85 kB 7.85 kB
Client Pages Modern
zeit/next.js canary robinweser/next.js patch-1 Change
_app.module.js gzip 598 B 598 B
_error.module.js gzip 2.09 kB 2.09 kB
hooks.module.js gzip 383 B 383 B
index.module.js gzip 223 B 223 B
link.module.js gzip 1.52 kB 1.52 kB
routerDirect..dule.js gzip 279 B 279 B
withRouter.m..dule.js gzip 278 B 278 B
Overall change 5.37 kB 5.37 kB
Client Build Manifests
zeit/next.js canary robinweser/next.js patch-1 Change
_buildManifest.js gzip 61 B 61 B
_buildManife..dule.js gzip 61 B 61 B
Overall change 122 B 122 B
Serverless bundles
zeit/next.js canary robinweser/next.js patch-1 Change
_error.js 558 kB 558 kB
404.html 4.18 kB 4.18 kB
hooks.html 3.81 kB 3.81 kB
index.js 558 kB 558 kB
link.js 595 kB 595 kB
routerDirect.js 587 kB 587 kB
withRouter.js 587 kB 587 kB
Overall change 2.89 MB 2.89 MB

@Timer Timer added the examples Issue/PR related to examples label May 2, 2020
@Timer Timer added this to the 9.3.7 milestone May 2, 2020
@Timer Timer merged commit b5b8cd8 into vercel:canary May 2, 2020
@Timer Timer modified the milestones: 9.3.7, 9.4 May 11, 2020
rokinsky pushed a commit to rokinsky/next.js that referenced this pull request Jul 11, 2020
@vercel vercel locked as resolved and limited conversation to collaborators Jan 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
examples Issue/PR related to examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants