Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#12314 add auth to with-sentry-simple example #12316

Merged
merged 3 commits into from
May 2, 2020
Merged

#12314 add auth to with-sentry-simple example #12316

merged 3 commits into from
May 2, 2020

Conversation

leonclaus
Copy link
Contributor

@leonclaus leonclaus commented Apr 29, 2020 •
edited by Timer

Fixes #12314. However, whether the solution is optimal is TBD.

Furthermore, I put the SENTRY_DSN environment variable into the envobject in next.config.js. However, it is not 100% clear to me whether this is correct.

@ijjk
Copy link
Member

ijjk commented Apr 29, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General
zeit/next.js canary lncls/next.js with-sentry-simple-includes-auth Change
buildDuration 13.5s 13.3s -219ms
nodeModulesSize 55.2 MB 55.2 MB ✓
Page Load Tests Overall increase ✓
zeit/next.js canary lncls/next.js with-sentry-simple-includes-auth Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.307 2.267 -0.04
/ avg req/sec 1083.8 1102.69 ⚠️ +18.89
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.376 1.239 -0.14
/error-in-render avg req/sec 1817.51 2018.14 ⚠️ +200.63
Client Bundles (main, webpack, commons)
zeit/next.js canary lncls/next.js with-sentry-simple-includes-auth Change
main-HASH.js gzip 6.27 kB 6.27 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..e8e1.js gzip 10.3 kB 10.3 kB ✓
framework.a1..NSE.txt gzip 220 B 220 B ✓
framework.a1..NSE.txt gzip 220 B 220 B ✓
framework.HASH.js gzip 39.2 kB 39.2 kB ✓
Overall change 56.9 kB 56.9 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary lncls/next.js with-sentry-simple-includes-auth Change
main-HASH.module.js gzip 4.82 kB 4.82 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.88 kB 6.88 kB ✓
framework.HA..dule.js gzip 39.2 kB 39.2 kB ✓
Overall change 51.7 kB 51.7 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary lncls/next.js with-sentry-simple-includes-auth Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary lncls/next.js with-sentry-simple-includes-auth Change
_app.js gzip 1.23 kB 1.23 kB ✓
_error.js gzip 3.15 kB 3.15 kB ✓
hooks.js gzip 663 B 663 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.06 kB 2.06 kB ✓
routerDirect.js gzip 280 B 280 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.88 kB 7.88 kB ✓
Client Pages Modern
zeit/next.js canary lncls/next.js with-sentry-simple-includes-auth Change
_app.module.js gzip 598 B 598 B ✓
_error.module.js gzip 2.09 kB 2.09 kB ✓
hooks.module.js gzip 383 B 383 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js gzip 1.52 kB 1.52 kB ✓
routerDirect..dule.js gzip 279 B 279 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 5.37 kB 5.37 kB ✓
Client Build Manifests
zeit/next.js canary lncls/next.js with-sentry-simple-includes-auth Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes
zeit/next.js canary lncls/next.js with-sentry-simple-includes-auth Change
index.html gzip 925 B 925 B ✓
link.html gzip 936 B 936 B ✓
withRouter.html gzip 924 B 924 B ✓
Overall change 2.79 kB 2.79 kB ✓
Serverless Mode
General
zeit/next.js canary lncls/next.js with-sentry-simple-includes-auth Change
buildDuration 13.6s 13.3s -332ms
nodeModulesSize 55.2 MB 55.2 MB ✓
Client Bundles (main, webpack, commons)
zeit/next.js canary lncls/next.js with-sentry-simple-includes-auth Change
main-HASH.js gzip 6.27 kB 6.27 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..e8e1.js gzip 10.3 kB 10.3 kB ✓
framework.a1..NSE.txt gzip 220 B 220 B ✓
framework.a1..NSE.txt gzip 220 B 220 B ✓
framework.HASH.js gzip 39.2 kB 39.2 kB ✓
Overall change 56.9 kB 56.9 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary lncls/next.js with-sentry-simple-includes-auth Change
main-HASH.module.js gzip 4.82 kB 4.82 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.88 kB 6.88 kB ✓
framework.HA..dule.js gzip 39.2 kB 39.2 kB ✓
Overall change 51.7 kB 51.7 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary lncls/next.js with-sentry-simple-includes-auth Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary lncls/next.js with-sentry-simple-includes-auth Change
_app.js gzip 1.23 kB 1.23 kB ✓
_error.js gzip 3.15 kB 3.15 kB ✓
hooks.js gzip 663 B 663 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.06 kB 2.06 kB ✓
routerDirect.js gzip 280 B 280 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.88 kB 7.88 kB ✓
Client Pages Modern
zeit/next.js canary lncls/next.js with-sentry-simple-includes-auth Change
_app.module.js gzip 598 B 598 B ✓
_error.module.js gzip 2.09 kB 2.09 kB ✓
hooks.module.js gzip 383 B 383 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js gzip 1.52 kB 1.52 kB ✓
routerDirect..dule.js gzip 279 B 279 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 5.37 kB 5.37 kB ✓
Client Build Manifests
zeit/next.js canary lncls/next.js with-sentry-simple-includes-auth Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles
zeit/next.js canary lncls/next.js with-sentry-simple-includes-auth Change
_error.js 557 kB 557 kB ✓
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.81 kB 3.81 kB ✓
index.js 557 kB 557 kB ✓
link.js 595 kB 595 kB ✓
routerDirect.js 587 kB 587 kB ✓
withRouter.js 588 kB 588 kB ✓
Overall change 2.89 MB 2.89 MB ✓

@leonclaus leonclaus mentioned this pull request Apr 29, 2020
Closed
@ijjk
Copy link
Member

ijjk commented Apr 29, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General
zeit/next.js canary lncls/next.js with-sentry-simple-includes-auth Change
buildDuration 13s 13.3s ⚠️ +278ms
nodeModulesSize 55.2 MB 55.2 MB ✓
Page Load Tests Overall increase ✓
zeit/next.js canary lncls/next.js with-sentry-simple-includes-auth Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.208 2.237 ⚠️ +0.03
/ avg req/sec 1132.49 1117.37 -15.12
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.276 1.257 -0.02
/error-in-render avg req/sec 1959.64 1988.42 ⚠️ +28.78
Client Bundles (main, webpack, commons)
zeit/next.js canary lncls/next.js with-sentry-simple-includes-auth Change
main-HASH.js gzip 6.27 kB 6.27 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..e8e1.js gzip 10.3 kB 10.3 kB ✓
framework.a1..NSE.txt gzip 220 B 220 B ✓
framework.a1..NSE.txt gzip 220 B 220 B ✓
framework.HASH.js gzip 39.2 kB 39.2 kB ✓
Overall change 56.9 kB 56.9 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary lncls/next.js with-sentry-simple-includes-auth Change
main-HASH.module.js gzip 4.82 kB 4.82 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.88 kB 6.88 kB ✓
framework.HA..dule.js gzip 39.2 kB 39.2 kB ✓
Overall change 51.7 kB 51.7 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary lncls/next.js with-sentry-simple-includes-auth Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary lncls/next.js with-sentry-simple-includes-auth Change
_app.js gzip 1.23 kB 1.23 kB ✓
_error.js gzip 3.15 kB 3.15 kB ✓
hooks.js gzip 663 B 663 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.06 kB 2.06 kB ✓
routerDirect.js gzip 280 B 280 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.88 kB 7.88 kB ✓
Client Pages Modern
zeit/next.js canary lncls/next.js with-sentry-simple-includes-auth Change
_app.module.js gzip 598 B 598 B ✓
_error.module.js gzip 2.09 kB 2.09 kB ✓
hooks.module.js gzip 383 B 383 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js gzip 1.52 kB 1.52 kB ✓
routerDirect..dule.js gzip 279 B 279 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 5.37 kB 5.37 kB ✓
Client Build Manifests
zeit/next.js canary lncls/next.js with-sentry-simple-includes-auth Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes
zeit/next.js canary lncls/next.js with-sentry-simple-includes-auth Change
index.html gzip 925 B 925 B ✓
link.html gzip 936 B 936 B ✓
withRouter.html gzip 924 B 924 B ✓
Overall change 2.79 kB 2.79 kB ✓
Serverless Mode
General
zeit/next.js canary lncls/next.js with-sentry-simple-includes-auth Change
buildDuration 13.7s 13.8s ⚠️ +89ms
nodeModulesSize 55.2 MB 55.2 MB ✓
Client Bundles (main, webpack, commons)
zeit/next.js canary lncls/next.js with-sentry-simple-includes-auth Change
main-HASH.js gzip 6.27 kB 6.27 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..e8e1.js gzip 10.3 kB 10.3 kB ✓
framework.a1..NSE.txt gzip 220 B 220 B ✓
framework.a1..NSE.txt gzip 220 B 220 B ✓
framework.HASH.js gzip 39.2 kB 39.2 kB ✓
Overall change 56.9 kB 56.9 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary lncls/next.js with-sentry-simple-includes-auth Change
main-HASH.module.js gzip 4.82 kB 4.82 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.88 kB 6.88 kB ✓
framework.HA..dule.js gzip 39.2 kB 39.2 kB ✓
Overall change 51.7 kB 51.7 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary lncls/next.js with-sentry-simple-includes-auth Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary lncls/next.js with-sentry-simple-includes-auth Change
_app.js gzip 1.23 kB 1.23 kB ✓
_error.js gzip 3.15 kB 3.15 kB ✓
hooks.js gzip 663 B 663 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.06 kB 2.06 kB ✓
routerDirect.js gzip 280 B 280 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.88 kB 7.88 kB ✓
Client Pages Modern
zeit/next.js canary lncls/next.js with-sentry-simple-includes-auth Change
_app.module.js gzip 598 B 598 B ✓
_error.module.js gzip 2.09 kB 2.09 kB ✓
hooks.module.js gzip 383 B 383 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js gzip 1.52 kB 1.52 kB ✓
routerDirect..dule.js gzip 279 B 279 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 5.37 kB 5.37 kB ✓
Client Build Manifests
zeit/next.js canary lncls/next.js with-sentry-simple-includes-auth Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles
zeit/next.js canary lncls/next.js with-sentry-simple-includes-auth Change
_error.js 557 kB 557 kB ✓
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.81 kB 3.81 kB ✓
index.js 557 kB 557 kB ✓
link.js 595 kB 595 kB ✓
routerDirect.js 587 kB 587 kB ✓
withRouter.js 588 kB 588 kB ✓
Overall change 2.89 MB 2.89 MB ✓

Timer
Timer approved these changes May 2, 2020
View reviewed changes
Copy link
Member

@Timer Timer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Timer Timer added the examples Issue/PR related to examples label May 2, 2020
@Timer Timer added this to the 9.3.7 milestone May 2, 2020
@Timer Timer merged commit ae1857e into vercel:canary May 2, 2020
@Timer Timer modified the milestones: 9.3.7, 9.4 May 11, 2020
rokinsky pushed a commit to rokinsky/next.js that referenced this pull request Jul 11, 2020
@leonclaus @rokinsky
vercel#12314 add auth to with-sentry-simple example (vercel#12316)
4f3c12c
@vercel vercel locked as resolved and limited conversation to collaborators Jan 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Timer Timer Timer approved these changes

@lfades lfades Awaiting requested review from lfades

Assignees
No one assigned
Labels
examples Issue/PR related to examples
Projects
None yet
Milestone
9.4
Development

Successfully merging this pull request may close these issues.

with-sentry-simple requires auth to upload sourcemaps via webpack plugin
3 participants
@leonclaus @ijjk @Timer