Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cors example and update API routes docs #12390

Merged
merged 3 commits into from
May 2, 2020

Conversation

lfades
Copy link
Member

@lfades lfades commented May 1, 2020

  • Added CORS example as it has been requested multiple times
  • Added the above example to docs
  • Added links to the api-routes examples in more sections of the API Routes documentation, and start the details tag with them opened
  • Added related link to the dynamic routes documentation to the dynamic routes section of API Routes

@lfades lfades requested a review from chibicode May 1, 2020 17:12
@lfades lfades requested a review from Timer as a code owner May 1, 2020 17:12
@ijjk
Copy link
Member

ijjk commented May 1, 2020

Stats from current PR

Default Server Mode
General
zeit/next.js canary lfades/next.js examples/api-routes-cors Change
buildDuration 12.3s 12.4s ⚠️ +114ms
nodeModulesSize 56.3 MB 56.3 MB
Page Load Tests Overall increase ✓
zeit/next.js canary lfades/next.js examples/api-routes-cors Change
/ failed reqs 0 0
/ total time (seconds) 2.111 2.071 -0.04
/ avg req/sec 1184.46 1207.35 ⚠️ +22.89
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.268 1.28 ⚠️ +0.01
/error-in-render avg req/sec 1971.17 1952.97 -18.2
Client Bundles (main, webpack, commons)
zeit/next.js canary lfades/next.js examples/api-routes-cors Change
main-HASH.js gzip 6.28 kB 6.28 kB
webpack-HASH.js gzip 746 B 746 B
de003c3a9d30..5232.js gzip 10.3 kB 10.3 kB
framework.a1..NSE.txt gzip 220 B 220 B
framework.a1..NSE.txt gzip 220 B 220 B
framework.HASH.js gzip 39.2 kB 39.2 kB
Overall change 57 kB 57 kB
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary lfades/next.js examples/api-routes-cors Change
main-HASH.module.js gzip 4.82 kB 4.82 kB
webpack-HASH..dule.js gzip 746 B 746 B
de003c3a9d30..dule.js gzip 6.88 kB 6.88 kB
framework.HA..dule.js gzip 39.2 kB 39.2 kB
Overall change 51.7 kB 51.7 kB
Legacy Client Bundles (polyfills)
zeit/next.js canary lfades/next.js examples/api-routes-cors Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB
Overall change 26.3 kB 26.3 kB
Client Pages
zeit/next.js canary lfades/next.js examples/api-routes-cors Change
_app.js gzip 1.23 kB 1.23 kB
_error.js gzip 3.13 kB 3.13 kB
hooks.js gzip 663 B 663 B
index.js gzip 222 B 222 B
link.js gzip 2.06 kB 2.06 kB
routerDirect.js gzip 280 B 280 B
withRouter.js gzip 278 B 278 B
Overall change 7.86 kB 7.86 kB
Client Pages Modern
zeit/next.js canary lfades/next.js examples/api-routes-cors Change
_app.module.js gzip 598 B 598 B
_error.module.js gzip 2.09 kB 2.09 kB
hooks.module.js gzip 383 B 383 B
index.module.js gzip 223 B 223 B
link.module.js gzip 1.52 kB 1.52 kB
routerDirect..dule.js gzip 279 B 279 B
withRouter.m..dule.js gzip 278 B 278 B
Overall change 5.37 kB 5.37 kB
Client Build Manifests
zeit/next.js canary lfades/next.js examples/api-routes-cors Change
_buildManifest.js gzip 61 B 61 B
_buildManife..dule.js gzip 61 B 61 B
Overall change 122 B 122 B
Rendered Page Sizes
zeit/next.js canary lfades/next.js examples/api-routes-cors Change
index.html gzip 926 B 926 B
link.html gzip 936 B 936 B
withRouter.html gzip 924 B 924 B
Overall change 2.79 kB 2.79 kB

Serverless Mode
General
zeit/next.js canary lfades/next.js examples/api-routes-cors Change
buildDuration 13s 13.2s ⚠️ +250ms
nodeModulesSize 56.3 MB 56.3 MB
Client Bundles (main, webpack, commons)
zeit/next.js canary lfades/next.js examples/api-routes-cors Change
main-HASH.js gzip 6.28 kB 6.28 kB
webpack-HASH.js gzip 746 B 746 B
de003c3a9d30..5232.js gzip 10.3 kB 10.3 kB
framework.a1..NSE.txt gzip 220 B 220 B
framework.a1..NSE.txt gzip 220 B 220 B
framework.HASH.js gzip 39.2 kB 39.2 kB
Overall change 57 kB 57 kB
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary lfades/next.js examples/api-routes-cors Change
main-HASH.module.js gzip 4.82 kB 4.82 kB
webpack-HASH..dule.js gzip 746 B 746 B
de003c3a9d30..dule.js gzip 6.88 kB 6.88 kB
framework.HA..dule.js gzip 39.2 kB 39.2 kB
Overall change 51.7 kB 51.7 kB
Legacy Client Bundles (polyfills)
zeit/next.js canary lfades/next.js examples/api-routes-cors Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB
Overall change 26.3 kB 26.3 kB
Client Pages
zeit/next.js canary lfades/next.js examples/api-routes-cors Change
_app.js gzip 1.23 kB 1.23 kB
_error.js gzip 3.13 kB 3.13 kB
hooks.js gzip 663 B 663 B
index.js gzip 222 B 222 B
link.js gzip 2.06 kB 2.06 kB
routerDirect.js gzip 280 B 280 B
withRouter.js gzip 278 B 278 B
Overall change 7.86 kB 7.86 kB
Client Pages Modern
zeit/next.js canary lfades/next.js examples/api-routes-cors Change
_app.module.js gzip 598 B 598 B
_error.module.js gzip 2.09 kB 2.09 kB
hooks.module.js gzip 383 B 383 B
index.module.js gzip 223 B 223 B
link.module.js gzip 1.52 kB 1.52 kB
routerDirect..dule.js gzip 279 B 279 B
withRouter.m..dule.js gzip 278 B 278 B
Overall change 5.37 kB 5.37 kB
Client Build Manifests
zeit/next.js canary lfades/next.js examples/api-routes-cors Change
_buildManifest.js gzip 61 B 61 B
_buildManife..dule.js gzip 61 B 61 B
Overall change 122 B 122 B
Serverless bundles
zeit/next.js canary lfades/next.js examples/api-routes-cors Change
_error.js 853 kB 853 kB
404.html 4.18 kB 4.18 kB
hooks.html 3.81 kB 3.81 kB
index.js 853 kB 853 kB
link.js 891 kB 891 kB
routerDirect.js 883 kB 883 kB
withRouter.js 883 kB 883 kB
Overall change 4.37 MB 4.37 MB

Copy link
Member

@Timer Timer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Timer Timer added the examples Issue/PR related to examples label May 2, 2020
@Timer Timer added this to the 9.3.7 milestone May 2, 2020
@Timer Timer merged commit 8259612 into vercel:canary May 2, 2020
@Timer Timer modified the milestones: 9.3.7, 9.4 May 11, 2020
rokinsky pushed a commit to rokinsky/next.js that referenced this pull request Jul 11, 2020
@vercel vercel locked as resolved and limited conversation to collaborators Jan 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
examples Issue/PR related to examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants