Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add names to components in amp example #12415

Merged
merged 1 commit into from
May 2, 2020
Merged

Add names to components in amp example #12415

merged 1 commit into from
May 2, 2020

Conversation

taylorbryant
Copy link
Contributor

This PR adds names to the components in the amp example.

This was sparked by @gaearon's post on Twitter.

@ijjk
Copy link
Member

ijjk commented May 2, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
zeit/next.js canary taylorbryant/next.js use-named-exports-in-amp-example Change
buildDuration 13.5s 13.8s ⚠️ +261ms
nodeModulesSize 57.5 MB 57.5 MB
Page Load Tests Overall decrease ⚠️
zeit/next.js canary taylorbryant/next.js use-named-exports-in-amp-example Change
/ failed reqs 0 0
/ total time (seconds) 2.333 2.315 -0.02
/ avg req/sec 1071.48 1079.72 ⚠️ +8.24
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.528 1.55 ⚠️ +0.02
/error-in-render avg req/sec 1635.8 1612.94 -22.86
Client Bundles (main, webpack, commons)
zeit/next.js canary taylorbryant/next.js use-named-exports-in-amp-example Change
main-HASH.js gzip 6.28 kB 6.28 kB
webpack-HASH.js gzip 746 B 746 B
de003c3a9d30..5232.js gzip 10.3 kB 10.3 kB
framework.a1..NSE.txt gzip 220 B 220 B
framework.a1..NSE.txt gzip 220 B 220 B
framework.HASH.js gzip 39.2 kB 39.2 kB
Overall change 57 kB 57 kB
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary taylorbryant/next.js use-named-exports-in-amp-example Change
main-HASH.module.js gzip 4.82 kB 4.82 kB
webpack-HASH..dule.js gzip 746 B 746 B
de003c3a9d30..dule.js gzip 6.88 kB 6.88 kB
framework.HA..dule.js gzip 39.2 kB 39.2 kB
Overall change 51.7 kB 51.7 kB
Legacy Client Bundles (polyfills)
zeit/next.js canary taylorbryant/next.js use-named-exports-in-amp-example Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB
Overall change 26.3 kB 26.3 kB
Client Pages
zeit/next.js canary taylorbryant/next.js use-named-exports-in-amp-example Change
_app.js gzip 1.23 kB 1.23 kB
_error.js gzip 3.13 kB 3.13 kB
hooks.js gzip 663 B 663 B
index.js gzip 222 B 222 B
link.js gzip 2.06 kB 2.06 kB
routerDirect.js gzip 280 B 280 B
withRouter.js gzip 278 B 278 B
Overall change 7.86 kB 7.86 kB
Client Pages Modern
zeit/next.js canary taylorbryant/next.js use-named-exports-in-amp-example Change
_app.module.js gzip 598 B 598 B
_error.module.js gzip 2.09 kB 2.09 kB
hooks.module.js gzip 383 B 383 B
index.module.js gzip 223 B 223 B
link.module.js gzip 1.52 kB 1.52 kB
routerDirect..dule.js gzip 279 B 279 B
withRouter.m..dule.js gzip 278 B 278 B
Overall change 5.37 kB 5.37 kB
Client Build Manifests
zeit/next.js canary taylorbryant/next.js use-named-exports-in-amp-example Change
_buildManifest.js gzip 61 B 61 B
_buildManife..dule.js gzip 61 B 61 B
Overall change 122 B 122 B
Rendered Page Sizes
zeit/next.js canary taylorbryant/next.js use-named-exports-in-amp-example Change
index.html gzip 927 B 927 B
link.html gzip 936 B 936 B
withRouter.html gzip 925 B 925 B
Overall change 2.79 kB 2.79 kB

Serverless Mode
General
zeit/next.js canary taylorbryant/next.js use-named-exports-in-amp-example Change
buildDuration 14.5s 14.9s ⚠️ +417ms
nodeModulesSize 57.5 MB 57.5 MB
Client Bundles (main, webpack, commons)
zeit/next.js canary taylorbryant/next.js use-named-exports-in-amp-example Change
main-HASH.js gzip 6.28 kB 6.28 kB
webpack-HASH.js gzip 746 B 746 B
de003c3a9d30..5232.js gzip 10.3 kB 10.3 kB
framework.a1..NSE.txt gzip 220 B 220 B
framework.a1..NSE.txt gzip 220 B 220 B
framework.HASH.js gzip 39.2 kB 39.2 kB
Overall change 57 kB 57 kB
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary taylorbryant/next.js use-named-exports-in-amp-example Change
main-HASH.module.js gzip 4.82 kB 4.82 kB
webpack-HASH..dule.js gzip 746 B 746 B
de003c3a9d30..dule.js gzip 6.88 kB 6.88 kB
framework.HA..dule.js gzip 39.2 kB 39.2 kB
Overall change 51.7 kB 51.7 kB
Legacy Client Bundles (polyfills)
zeit/next.js canary taylorbryant/next.js use-named-exports-in-amp-example Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB
Overall change 26.3 kB 26.3 kB
Client Pages
zeit/next.js canary taylorbryant/next.js use-named-exports-in-amp-example Change
_app.js gzip 1.23 kB 1.23 kB
_error.js gzip 3.13 kB 3.13 kB
hooks.js gzip 663 B 663 B
index.js gzip 222 B 222 B
link.js gzip 2.06 kB 2.06 kB
routerDirect.js gzip 280 B 280 B
withRouter.js gzip 278 B 278 B
Overall change 7.86 kB 7.86 kB
Client Pages Modern
zeit/next.js canary taylorbryant/next.js use-named-exports-in-amp-example Change
_app.module.js gzip 598 B 598 B
_error.module.js gzip 2.09 kB 2.09 kB
hooks.module.js gzip 383 B 383 B
index.module.js gzip 223 B 223 B
link.module.js gzip 1.52 kB 1.52 kB
routerDirect..dule.js gzip 279 B 279 B
withRouter.m..dule.js gzip 278 B 278 B
Overall change 5.37 kB 5.37 kB
Client Build Manifests
zeit/next.js canary taylorbryant/next.js use-named-exports-in-amp-example Change
_buildManifest.js gzip 61 B 61 B
_buildManife..dule.js gzip 61 B 61 B
Overall change 122 B 122 B
Serverless bundles
zeit/next.js canary taylorbryant/next.js use-named-exports-in-amp-example Change
_error.js 853 kB 853 kB
404.html 4.18 kB 4.18 kB
hooks.html 3.81 kB 3.81 kB
index.js 853 kB 853 kB
link.js 891 kB 891 kB
routerDirect.js 883 kB 883 kB
withRouter.js 883 kB 883 kB
Overall change 4.37 MB 4.37 MB

@Timer Timer added the examples Issue/PR related to examples label May 2, 2020
@Timer Timer added this to the 9.3.7 milestone May 2, 2020
@Timer Timer merged commit 96f8455 into vercel:canary May 2, 2020
@Timer Timer modified the milestones: 9.3.7, 9.4 May 11, 2020
rokinsky pushed a commit to rokinsky/next.js that referenced this pull request Jul 11, 2020
@vercel vercel locked as resolved and limited conversation to collaborators Jan 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
examples Issue/PR related to examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants