Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(examples): with-iron-session update #12418

Merged
merged 4 commits into from
May 3, 2020
Merged

docs(examples): with-iron-session update #12418

merged 4 commits into from
May 3, 2020

Conversation

vvo
Copy link
Member

@vvo vvo commented May 2, 2020

  • updated all dependencies
  • used jsx since this is what I use by default to distinguish from pure js
    files/api routes
  • removed some extraneous folders
  • changed the way we use swr for better defaults around mutate and default swr
    config
  • changed the way we logout
  • fixed small bug in profile-ssr around not sending empty props
  • added loading message instead of trying to display the static generated
    profile
  • added default cookie name to not conflict with other examples/localhosts

@vvo
docs(examples): with-iron-session update
b07d255 
+ updated all dependencies
+ used jsx since this is what I use by default to distinguish from pure js
files/api routes
+ removed some extraneous folders
+ changed the way we use swr for better defaults around mutate and default swr
config
+ changed the way we logout
+ fixed small bug in profile-ssr around not sending empty props
+ added loading message instead of trying to display the static generated
profile
+ added default cookie name to not conflict with other examples/localhosts
@vvo vvo requested review from lfades and Timer as code owners May 2, 2020 19:44
@vvo vvo mentioned this pull request May 2, 2020
Closed
Timer
Timer requested changes May 2, 2020
View reviewed changes
Copy link
Member

@Timer Timer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please use the .js extension? .jsx resolves slower / with the lowest priority, and only exists for backwards compatibility.

@ijjk
Copy link
Member

ijjk commented May 2, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
zeit/next.js canary vvo/next.js examples/with-iron-session-update-swr-flow Change
buildDuration 11.3s 11.2s -110ms
nodeModulesSize 57.5 MB 57.5 MB ✓
Page Load Tests Overall decrease ⚠️
zeit/next.js canary vvo/next.js examples/with-iron-session-update-swr-flow Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.891 1.945 ⚠️ +0.05
/ avg req/sec 1322.19 1285.55 -36.64
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.101 1.121 ⚠️ +0.02
/error-in-render avg req/sec 2270.91 2230.01 -40.9
Client Bundles (main, webpack, commons)
zeit/next.js canary vvo/next.js examples/with-iron-session-update-swr-flow Change
main-HASH.js gzip 6.28 kB 6.28 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..5232.js gzip 10.3 kB 10.3 kB ✓
framework.a1..NSE.txt gzip 220 B 220 B ✓
framework.a1..NSE.txt gzip 220 B 220 B ✓
framework.HASH.js gzip 39.2 kB 39.2 kB ✓
Overall change 57 kB 57 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary vvo/next.js examples/with-iron-session-update-swr-flow Change
main-HASH.module.js gzip 4.82 kB 4.82 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.88 kB 6.88 kB ✓
framework.HA..dule.js gzip 39.2 kB 39.2 kB ✓
Overall change 51.7 kB 51.7 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary vvo/next.js examples/with-iron-session-update-swr-flow Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary vvo/next.js examples/with-iron-session-update-swr-flow Change
_app.js gzip 1.23 kB 1.23 kB ✓
_error.js gzip 3.13 kB 3.13 kB ✓
hooks.js gzip 663 B 663 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.06 kB 2.06 kB ✓
routerDirect.js gzip 280 B 280 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.86 kB 7.86 kB ✓
Client Pages Modern
zeit/next.js canary vvo/next.js examples/with-iron-session-update-swr-flow Change
_app.module.js gzip 598 B 598 B ✓
_error.module.js gzip 2.09 kB 2.09 kB ✓
hooks.module.js gzip 383 B 383 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js gzip 1.52 kB 1.52 kB ✓
routerDirect..dule.js gzip 279 B 279 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 5.37 kB 5.37 kB ✓
Client Build Manifests
zeit/next.js canary vvo/next.js examples/with-iron-session-update-swr-flow Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes
zeit/next.js canary vvo/next.js examples/with-iron-session-update-swr-flow Change
index.html gzip 927 B 927 B ✓
link.html gzip 936 B 936 B ✓
withRouter.html gzip 925 B 925 B ✓
Overall change 2.79 kB 2.79 kB ✓
Serverless Mode
General
zeit/next.js canary vvo/next.js examples/with-iron-session-update-swr-flow Change
buildDuration 12.3s 12.1s -212ms
nodeModulesSize 57.5 MB 57.5 MB ✓
Client Bundles (main, webpack, commons)
zeit/next.js canary vvo/next.js examples/with-iron-session-update-swr-flow Change
main-HASH.js gzip 6.28 kB 6.28 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..5232.js gzip 10.3 kB 10.3 kB ✓
framework.a1..NSE.txt gzip 220 B 220 B ✓
framework.a1..NSE.txt gzip 220 B 220 B ✓
framework.HASH.js gzip 39.2 kB 39.2 kB ✓
Overall change 57 kB 57 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary vvo/next.js examples/with-iron-session-update-swr-flow Change
main-HASH.module.js gzip 4.82 kB 4.82 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.88 kB 6.88 kB ✓
framework.HA..dule.js gzip 39.2 kB 39.2 kB ✓
Overall change 51.7 kB 51.7 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary vvo/next.js examples/with-iron-session-update-swr-flow Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary vvo/next.js examples/with-iron-session-update-swr-flow Change
_app.js gzip 1.23 kB 1.23 kB ✓
_error.js gzip 3.13 kB 3.13 kB ✓
hooks.js gzip 663 B 663 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.06 kB 2.06 kB ✓
routerDirect.js gzip 280 B 280 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.86 kB 7.86 kB ✓
Client Pages Modern
zeit/next.js canary vvo/next.js examples/with-iron-session-update-swr-flow Change
_app.module.js gzip 598 B 598 B ✓
_error.module.js gzip 2.09 kB 2.09 kB ✓
hooks.module.js gzip 383 B 383 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js gzip 1.52 kB 1.52 kB ✓
routerDirect..dule.js gzip 279 B 279 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 5.37 kB 5.37 kB ✓
Client Build Manifests
zeit/next.js canary vvo/next.js examples/with-iron-session-update-swr-flow Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles
zeit/next.js canary vvo/next.js examples/with-iron-session-update-swr-flow Change
_error.js 853 kB 853 kB ✓
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.81 kB 3.81 kB ✓
index.js 853 kB 853 kB ✓
link.js 891 kB 891 kB ✓
routerDirect.js 883 kB 883 kB ✓
withRouter.js 883 kB 883 kB ✓
Overall change 4.37 MB 4.37 MB ✓

@vvo
Copy link
Member Author

vvo commented May 2, 2020

Can you please use the .js extension? .jsx resolves slower / with the lowest priority, and only exists for backwards compatibility.

Ah! That's news to me, I guess we should add this to the docs (with some source information?). Because I am using jsx everywhere, I find it better suited since those aren't actual compatible JavaScript files when they contain JSX.

Yes I will do the change then

@vvo
Copy link
Member Author

vvo commented May 2, 2020

Can you please use the .js extension?

Done

@vvo vvo requested a review from Timer May 2, 2020 19:59
@ijjk
Copy link
Member

ijjk commented May 2, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General
zeit/next.js canary vvo/next.js examples/with-iron-session-update-swr-flow Change
buildDuration 13.2s 13.2s -75ms
nodeModulesSize 57.5 MB 57.5 MB ✓
Page Load Tests Overall increase ✓
zeit/next.js canary vvo/next.js examples/with-iron-session-update-swr-flow Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.3 2.264 -0.04
/ avg req/sec 1086.87 1104 ⚠️ +17.13
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.464 1.42 -0.04
/error-in-render avg req/sec 1708.01 1760.77 ⚠️ +52.76
Client Bundles (main, webpack, commons)
zeit/next.js canary vvo/next.js examples/with-iron-session-update-swr-flow Change
main-HASH.js gzip 6.28 kB 6.28 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..5232.js gzip 10.3 kB 10.3 kB ✓
framework.a1..NSE.txt gzip 220 B 220 B ✓
framework.a1..NSE.txt gzip 220 B 220 B ✓
framework.HASH.js gzip 39.2 kB 39.2 kB ✓
Overall change 57 kB 57 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary vvo/next.js examples/with-iron-session-update-swr-flow Change
main-HASH.module.js gzip 4.82 kB 4.82 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.88 kB 6.88 kB ✓
framework.HA..dule.js gzip 39.2 kB 39.2 kB ✓
Overall change 51.7 kB 51.7 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary vvo/next.js examples/with-iron-session-update-swr-flow Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary vvo/next.js examples/with-iron-session-update-swr-flow Change
_app.js gzip 1.23 kB 1.23 kB ✓
_error.js gzip 3.13 kB 3.13 kB ✓
hooks.js gzip 663 B 663 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.06 kB 2.06 kB ✓
routerDirect.js gzip 280 B 280 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.86 kB 7.86 kB ✓
Client Pages Modern
zeit/next.js canary vvo/next.js examples/with-iron-session-update-swr-flow Change
_app.module.js gzip 598 B 598 B ✓
_error.module.js gzip 2.09 kB 2.09 kB ✓
hooks.module.js gzip 383 B 383 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js gzip 1.52 kB 1.52 kB ✓
routerDirect..dule.js gzip 279 B 279 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 5.37 kB 5.37 kB ✓
Client Build Manifests
zeit/next.js canary vvo/next.js examples/with-iron-session-update-swr-flow Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes
zeit/next.js canary vvo/next.js examples/with-iron-session-update-swr-flow Change
index.html gzip 927 B 927 B ✓
link.html gzip 936 B 936 B ✓
withRouter.html gzip 925 B 925 B ✓
Overall change 2.79 kB 2.79 kB ✓
Serverless Mode
General
zeit/next.js canary vvo/next.js examples/with-iron-session-update-swr-flow Change
buildDuration 14.1s 14.4s ⚠️ +329ms
nodeModulesSize 57.5 MB 57.5 MB ✓
Client Bundles (main, webpack, commons)
zeit/next.js canary vvo/next.js examples/with-iron-session-update-swr-flow Change
main-HASH.js gzip 6.28 kB 6.28 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..5232.js gzip 10.3 kB 10.3 kB ✓
framework.a1..NSE.txt gzip 220 B 220 B ✓
framework.a1..NSE.txt gzip 220 B 220 B ✓
framework.HASH.js gzip 39.2 kB 39.2 kB ✓
Overall change 57 kB 57 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary vvo/next.js examples/with-iron-session-update-swr-flow Change
main-HASH.module.js gzip 4.82 kB 4.82 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.88 kB 6.88 kB ✓
framework.HA..dule.js gzip 39.2 kB 39.2 kB ✓
Overall change 51.7 kB 51.7 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary vvo/next.js examples/with-iron-session-update-swr-flow Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary vvo/next.js examples/with-iron-session-update-swr-flow Change
_app.js gzip 1.23 kB 1.23 kB ✓
_error.js gzip 3.13 kB 3.13 kB ✓
hooks.js gzip 663 B 663 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.06 kB 2.06 kB ✓
routerDirect.js gzip 280 B 280 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.86 kB 7.86 kB ✓
Client Pages Modern
zeit/next.js canary vvo/next.js examples/with-iron-session-update-swr-flow Change
_app.module.js gzip 598 B 598 B ✓
_error.module.js gzip 2.09 kB 2.09 kB ✓
hooks.module.js gzip 383 B 383 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js gzip 1.52 kB 1.52 kB ✓
routerDirect..dule.js gzip 279 B 279 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 5.37 kB 5.37 kB ✓
Client Build Manifests
zeit/next.js canary vvo/next.js examples/with-iron-session-update-swr-flow Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles
zeit/next.js canary vvo/next.js examples/with-iron-session-update-swr-flow Change
_error.js 853 kB 853 kB ✓
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.81 kB 3.81 kB ✓
index.js 853 kB 853 kB ✓
link.js 891 kB 891 kB ✓
routerDirect.js 883 kB 883 kB ✓
withRouter.js 883 kB 883 kB ✓
Overall change 4.37 MB 4.37 MB ✓

@ijjk
Copy link
Member

ijjk commented May 2, 2020

Stats from current PR

Default Server Mode
General
zeit/next.js canary vvo/next.js examples/with-iron-session-update-swr-flow Change
buildDuration 14.2s 13.9s -309ms
nodeModulesSize 57.5 MB 57.5 MB ✓
Page Load Tests Overall increase ✓
zeit/next.js canary vvo/next.js examples/with-iron-session-update-swr-flow Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.429 2.427 0
/ avg req/sec 1029.23 1030.06 ⚠️ +0.83
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.566 1.564 0
/error-in-render avg req/sec 1596.22 1598.25 ⚠️ +2.03
Client Bundles (main, webpack, commons)
zeit/next.js canary vvo/next.js examples/with-iron-session-update-swr-flow Change
main-HASH.js gzip 6.28 kB 6.28 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..5232.js gzip 10.3 kB 10.3 kB ✓
framework.a1..NSE.txt gzip 220 B 220 B ✓
framework.a1..NSE.txt gzip 220 B 220 B ✓
framework.HASH.js gzip 39.2 kB 39.2 kB ✓
Overall change 57 kB 57 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary vvo/next.js examples/with-iron-session-update-swr-flow Change
main-HASH.module.js gzip 4.82 kB 4.82 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.88 kB 6.88 kB ✓
framework.HA..dule.js gzip 39.2 kB 39.2 kB ✓
Overall change 51.7 kB 51.7 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary vvo/next.js examples/with-iron-session-update-swr-flow Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary vvo/next.js examples/with-iron-session-update-swr-flow Change
_app.js gzip 1.23 kB 1.23 kB ✓
_error.js gzip 3.13 kB 3.13 kB ✓
hooks.js gzip 663 B 663 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.06 kB 2.06 kB ✓
routerDirect.js gzip 280 B 280 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.86 kB 7.86 kB ✓
Client Pages Modern
zeit/next.js canary vvo/next.js examples/with-iron-session-update-swr-flow Change
_app.module.js gzip 598 B 598 B ✓
_error.module.js gzip 2.09 kB 2.09 kB ✓
hooks.module.js gzip 383 B 383 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js gzip 1.52 kB 1.52 kB ✓
routerDirect..dule.js gzip 279 B 279 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 5.37 kB 5.37 kB ✓
Client Build Manifests
zeit/next.js canary vvo/next.js examples/with-iron-session-update-swr-flow Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes
zeit/next.js canary vvo/next.js examples/with-iron-session-update-swr-flow Change
index.html gzip 927 B 927 B ✓
link.html gzip 936 B 936 B ✓
withRouter.html gzip 925 B 925 B ✓
Overall change 2.79 kB 2.79 kB ✓
Serverless Mode
General
zeit/next.js canary vvo/next.js examples/with-iron-session-update-swr-flow Change
buildDuration 14.4s 14.5s ⚠️ +95ms
nodeModulesSize 57.5 MB 57.5 MB ✓
Client Bundles (main, webpack, commons)
zeit/next.js canary vvo/next.js examples/with-iron-session-update-swr-flow Change
main-HASH.js gzip 6.28 kB 6.28 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..5232.js gzip 10.3 kB 10.3 kB ✓
framework.a1..NSE.txt gzip 220 B 220 B ✓
framework.a1..NSE.txt gzip 220 B 220 B ✓
framework.HASH.js gzip 39.2 kB 39.2 kB ✓
Overall change 57 kB 57 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary vvo/next.js examples/with-iron-session-update-swr-flow Change
main-HASH.module.js gzip 4.82 kB 4.82 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.88 kB 6.88 kB ✓
framework.HA..dule.js gzip 39.2 kB 39.2 kB ✓
Overall change 51.7 kB 51.7 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary vvo/next.js examples/with-iron-session-update-swr-flow Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary vvo/next.js examples/with-iron-session-update-swr-flow Change
_app.js gzip 1.23 kB 1.23 kB ✓
_error.js gzip 3.13 kB 3.13 kB ✓
hooks.js gzip 663 B 663 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.06 kB 2.06 kB ✓
routerDirect.js gzip 280 B 280 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.86 kB 7.86 kB ✓
Client Pages Modern
zeit/next.js canary vvo/next.js examples/with-iron-session-update-swr-flow Change
_app.module.js gzip 598 B 598 B ✓
_error.module.js gzip 2.09 kB 2.09 kB ✓
hooks.module.js gzip 383 B 383 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js gzip 1.52 kB 1.52 kB ✓
routerDirect..dule.js gzip 279 B 279 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 5.37 kB 5.37 kB ✓
Client Build Manifests
zeit/next.js canary vvo/next.js examples/with-iron-session-update-swr-flow Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles
zeit/next.js canary vvo/next.js examples/with-iron-session-update-swr-flow Change
_error.js 853 kB 853 kB ✓
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.81 kB 3.81 kB ✓
index.js 853 kB 853 kB ✓
link.js 891 kB 891 kB ✓
routerDirect.js 883 kB 883 kB ✓
withRouter.js 883 kB 883 kB ✓
Overall change 4.37 MB 4.37 MB ✓

@Timer Timer added the examples Issue/PR related to examples label May 3, 2020
@Timer Timer added this to the 9.3.7 milestone May 3, 2020
@Timer Timer merged commit f38eb70 into vercel:canary May 3, 2020
@Timer Timer modified the milestones: 9.3.7, 9.4 May 11, 2020
rokinsky pushed a commit to rokinsky/next.js that referenced this pull request Jul 11, 2020
@vvo @rokinsky
docs(examples): with-iron-session update (vercel#12418)
f0576cb
@vercel vercel locked as resolved and limited conversation to collaborators Jan 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Timer Timer Timer approved these changes

@lfades lfades Awaiting requested review from lfades

Assignees
No one assigned
Labels
examples Issue/PR related to examples
Projects
None yet
Milestone
9.4
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vvo @ijjk @Timer