fix logout in with-iron-session example #12704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Very good catch @dpyzo0o thanks so much! LGTM! For Next.js maintainers: destroy already sets the right headers and save() is not required: worth it will restart a session. |
maxigimenez
reviewed
May 11, 2020
| @@ -2,6 +2,5 @@ import withSession from '../../lib/session' | |||
|
|
|||
| export default withSession(async (req, res) => { | |||
There was a problem hiding this comment.
async is no longer required
Timer
approved these changes
May 11, 2020
chibicode
pushed a commit
to chibicode/next.js
that referenced
this pull request
May 21, 2020
rokinsky
pushed a commit
to rokinsky/next.js
that referenced
this pull request
Jul 11, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@vvo
related vvo/iron-session#64