Remove pkg bundling (#2567)

* Remove `pkg` bundling

* Remove `(dev)` from `--version`

* Remove `test/dev-builder.unit.js`

* Temporary disable `update now to canary test`

* Update `now update` command

* Removed useless jobs

* Removed useless code

* Removed more useless code

* Use update command

* Only run publish upon tag

* Removed code

* No need bin, use dist directly

* Update test, using the right file

* Reslove `iconv-lite@0.5.0` version

* Removed useless file

* Added scripts directory

* Removed useless stuff

* Fixed build script

* Fix `now dev` integration test

* Also block coverage on linting

.circleci/config.yml

@@ -36,16 +36,15 @@ jobs:
       - attach_workspace:
           at: .
       - run:
-          name: Compiling Binaries
-          command: yarn run pack
+          name: Building
+          command: yarn build
       - store_artifacts:
-          path: packed
+          path: dist
       - persist_to_workspace:
           root: .
           paths:
-            - assets
+            - bin
             - dist
-            - packed
 
   test-lint:
     docker:
@@ -105,49 +104,6 @@ jobs:
           name: Run coverage report
           command: yarn coverage
 
-  compress:
-    docker:
-      - image: circleci/node:10
-    working_directory: ~/repo
-    steps:
-      - checkout
-      - attach_workspace:
-          at: .
-      - run:
-          name: Compressing Binaries
-          command: yarn gzip
-      - persist_to_workspace:
-          root: .
-          paths:
-            - packed
-
-  upload:
-    docker:
-      - image: circleci/golang:1.10
-    working_directory: ~/repo
-    steps:
-      - checkout
-      - attach_workspace:
-          at: .
-      - restore_cache:
-          keys:
-            - v1-pkg-cache
-      - run:
-          name: Installing Uploader
-          command: go get github.com/aktau/github-release
-      - run:
-          name: Uploading Binaries
-          command:
-            >-
-              for file in ./packed/*.gz;
-              do
-               github-release upload -R -t `git describe --tags` -n ${file##*/} -f $file
-              done
-      - save_cache:
-          key: v1-pkg-cache
-          paths:
-            - "/go/pkg"
-
   source-maps:
     docker:
       - image: circleci/node:10
@@ -235,34 +191,23 @@ workflows:
           requires:
             - test-unit
             - test-integration
-          filters:
-            tags:
-              only: /.*/
-      - compress:
-          requires:
             - test-lint
-            - test-integration
-            - test-unit
-          filters:
-            tags:
-              only: /.*/
-            branches:
-              ignore: /.*/
-      - upload:
-          requires:
-            - compress
           filters:
             tags:
               only: /.*/
       - publish-canary:
           requires:
-            - upload
+            - coverage
           filters:
             tags:
               only: /^.*canary.*($|\b)/
+            branches:
+              ignore: /.*/
       - publish-stable:
           requires:
-            - upload
+            - coverage
           filters:
             tags:
               only: /^(\d+\.)?(\d+\.)?(\*|\d+)$/
+            branches:
+              ignore: /.*/

.gitignore

@@ -1,7 +1,6 @@
 node_modules
 package-lock.json
 dist
-packed
 test/fixtures/integration
 npm-debug.log
 yarn-error.log

README.md

@@ -10,7 +10,7 @@
 To install the latest version of Now CLI, visit [zeit.co/download](https://zeit.co/download) or run this command:
 
 ```
-npm install -g now
+npm i -g now
 ```
 
 To quickly start a new project, run the following commands:
@@ -30,8 +30,9 @@ For details on how to use Now CLI, check out our [documentation](https://zeit.co
 
 1. [Fork](https://help.github.com/articles/fork-a-repo/) this repository to your own GitHub account and then [clone](https://help.github.com/articles/cloning-a-repository/) it to your local device
 2. Install dependencies with `yarn install`
-3. Link the package to the global module directory: `yarn run link` (not `yarn link`)
-4. You can now start using `now` anywhere inside the command line
+3. Compile the code: `yarn build`
+4. Link the package to the global module directory: `yarn link`
+5. You can now start using `now` anywhere inside the command line
 
 As always, you should use `yarn test` to run the tests and see if your changes have broken anything.