Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hot fix for now teams ls #1737

Merged
merged 2 commits into from Dec 10, 2018
Merged

Hot fix for now teams ls #1737

merged 2 commits into from Dec 10, 2018

Conversation

leo
Copy link
Contributor

@leo leo commented Dec 10, 2018

This code is useless, so we can remove it. The currentTeam variable is not read after it is overridden in this statement.

Also adds an integration test.

@codecov-io
Copy link

codecov-io commented Dec 10, 2018

Codecov Report

Merging #1737 into canary will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           canary    #1737   +/-   ##
=======================================
  Coverage   70.96%   70.96%           
=======================================
  Files          12       12           
  Lines         341      341           
=======================================
  Hits          242      242           
  Misses         99       99

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f444350...0e1741d. Read the comment docs.

@leo leo merged commit 7441730 into canary Dec 10, 2018
@leo leo deleted the teams-ls branch December 10, 2018 14:10
leo added a commit that referenced this pull request Dec 10, 2018
* Hot fix for `now teams ls`

* Added integration test
javivelasco added a commit that referenced this pull request Dec 10, 2018
* canary:
  13.0.0-canary.24
  Hot fix for `now teams ls` (#1737)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants