Added --scope flag and scope config property
#1939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit cfeebc6.
AndyBitz
approved these changes
Mar 12, 2019
Codecov Report
@@ Coverage Diff @@
## canary #1939 +/- ##
=========================================
- Coverage 6.33% 6.31% -0.02%
=========================================
Files 91 91
Lines 4074 4085 +11
=========================================
Hits 258 258
- Misses 3816 3827 +11
Continue to review full report at Codecov.
|
leo
added a commit
that referenced
this pull request
Mar 14, 2019
* Added basics for new --scope flag * Fixed usage information * Fixed integration test * Fixed usage information about whoami * Brought back missing whitespace * Do not push scope property to API * Ensure we're only reading local config in one place * Fixed build * Added test * Made scope from config work * Correctly handle error * Handle Now errors too when loading local config * Removed NowError * Revert "Removed NowError" This reverts commit cfeebc6. * Fixed CI * Fixed final bug * Do not consider switch command * Made it work as expected * Added test * Added yet another test for the scope property * Added space
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR, we're replacing
--teamwith a more straightforward--scopeflag (since that name covers both user accounts and teams).Furthermore, we're adding a
scopeproperty tonow.jsonfor the same purpose.