Improve eslint config #2042
Merged
Improve eslint config #2042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add `.ts` extension - Update dependencies related to eslint - Disabled two problemtic ruls temporally
Codecov Report
@@ Coverage Diff @@
## canary #2042 +/- ##
=========================================
+ Coverage 4.39% 4.39% +<.01%
=========================================
Files 243 243
Lines 8694 8693 -1
Branches 904 904
=========================================
Hits 382 382
+ Misses 8295 8294 -1
Partials 17 17
Continue to review full report at Codecov.
|
styfle
reviewed
Apr 9, 2019
styfle
reviewed
Apr 9, 2019
styfle
reviewed
Apr 9, 2019
styfle
reviewed
Apr 9, 2019
styfle
reviewed
Apr 9, 2019
styfle
approved these changes
Apr 9, 2019
|
Ping @leo @TooTallNate @javivelasco, could you help review this? 馃檹 |
leo
suggested changes
Apr 10, 2019
leo
approved these changes
Apr 11, 2019
leo
pushed a commit
that referenced
this pull request
Apr 11, 2019
- Get `.ts` files covered 馃帀 - Update eslint related dependencies - Add typescript-eslint [recommended rules](https://github.com/typescript-eslint/typescript-eslint/blob/3e26ab684ae5642e9c50940bedd155e32e189900/packages/eslint-plugin/src/configs/recommended.json), but only enabled ones we already followed, commented ones causing errors. Commented rules including: ```yaml # '@typescript-eslint/no-unused-vars': 1 # '@typescript-eslint/indent': ['error', 2] # '@typescript-eslint/array-type': error # '@typescript-eslint/ban-types': error # '@typescript-eslint/explicit-member-accessibility': error # '@typescript-eslint/member-delimiter-style': error # '@typescript-eslint/no-angle-bracket-type-assertion': error # '@typescript-eslint/no-explicit-any': warn # '@typescript-eslint/no-object-literal-type-assertion': error # '@typescript-eslint/no-use-before-define': error # '@typescript-eslint/no-var-requires': error # '@typescript-eslint/prefer-interface': error ``` ### TODO Go through these commented rules one by one, enable & fix for it or confirm it's disabled. Since enabling some rules would cause massive code change (like `'@typescript-eslint/indent': ['error', 2]`), which might conflict with our ongoing development, we better do this in separated PRs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.tsfiles covered 馃帀Commented rules including:
TODO
Go through these commented rules one by one, enable & fix for it or confirm it's disabled. Since enabling some rules would cause massive code change (like
'@typescript-eslint/indent': ['error', 2]), which might conflict with our ongoing development, we better do this in separated PRs.