Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[now dev] Add logging of the builder package versions #2125

Merged
merged 2 commits into from Apr 10, 2019

Conversation

TooTallNate
Copy link
Member

To aid in debugging errors reported by users.

To aid in debugging errors reported by users.
@TooTallNate TooTallNate requested review from amio, styfle and leo April 9, 2019 17:07
@codecov-io
Copy link

Codecov Report

Merging #2125 into canary will increase coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           canary   #2125      +/-   ##
=========================================
+ Coverage     4.5%   4.51%   +0.01%     
=========================================
  Files         243     243              
  Lines        8628    8630       +2     
  Branches      882     882              
=========================================
+ Hits          389     390       +1     
- Misses       8222    8223       +1     
  Partials       17      17
Impacted Files Coverage Δ
src/commands/dev/lib/dev-builder.ts 0% <0%> (ø) ⬆️
src/commands/dev/lib/builder-cache.ts 0% <0%> (ø) ⬆️
src/commands/dev/lib/types.ts 0% <0%> (ø) ⬆️
src/util/read-metadata.js 100% <0%> (ø) ⬆️
src/util/hash.js 100% <0%> (ø) ⬆️
src/util/error.js 100% <0%> (ø) ⬆️
src/util/get-files.js 96.89% <0%> (+5.36%) ⬆️
src/util/get-project-name.js 100% <0%> (+9.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c297d2...8fd39ec. Read the comment docs.

@TooTallNate TooTallNate merged commit 430696f into canary Apr 10, 2019
@TooTallNate TooTallNate deleted the update/add-builder-version-logging branch April 10, 2019 01:50
leo pushed a commit that referenced this pull request Apr 11, 2019
* [now dev] Add logging of the builder package versions

To aid in debugging errors reported by users.

* Remove bad
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants