Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[now dev] Implement methods in routes config #2306

Merged
merged 1 commit into from May 3, 2019

Conversation

TooTallNate
Copy link
Member

Fixes #2148.

@codecov-io
Copy link

Codecov Report

Merging #2306 into canary will increase coverage by 0.01%.
The diff coverage is 75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           canary    #2306      +/-   ##
==========================================
+ Coverage   10.64%   10.66%   +0.01%     
==========================================
  Files         247      247              
  Lines        9040     9042       +2     
  Branches      992      993       +1     
==========================================
+ Hits          962      964       +2     
  Misses       7963     7963              
  Partials      115      115
Impacted Files Coverage Δ
src/commands/dev/lib/dev-server.ts 40.41% <66.66%> (ø) ⬆️
src/commands/dev/lib/dev-router.ts 79.24% <85.71%> (+0.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ab7179...eacd959. Read the comment docs.

@leo leo merged commit cf51fdb into canary May 3, 2019
@leo leo deleted the update/now-dev-routes-methods branch May 3, 2019 12:21
TooTallNate added a commit that referenced this pull request May 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

now dev is not respecting methods of routes
3 participants