[now dev] Use empty string for missing matches #2376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than `undefined`. This matches the behavior in production. Fixes #2375.
leo
approved these changes
May 22, 2019
styfle
approved these changes
May 22, 2019
Codecov Report
@@ Coverage Diff @@
## canary #2376 +/- ##
======================================
Coverage 10.9% 10.9%
======================================
Files 250 250
Lines 9031 9031
Branches 990 991 +1
======================================
Hits 985 985
Misses 7945 7945
Partials 101 101
Continue to review full report at Codecov.
|
TooTallNate
added a commit
that referenced
this pull request
Jun 5, 2019
Rather than `undefined`. This matches the behavior in production. Fixes #2375.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than
undefined. This matches the behavior in production.Fixes #2375.