Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[now deploy] Use the project when checking the platform version #2722

Merged
merged 5 commits into from Aug 7, 2019

Conversation

AndyBitz
Copy link
Contributor

@AndyBitz AndyBitz commented Aug 7, 2019

Use the project when checking the platform version

src/util/prefer-v2-deployment.ts Outdated Show resolved Hide resolved
src/util/prefer-v2-deployment.ts Outdated Show resolved Hide resolved
AndyBitz and others added 3 commits August 7, 2019 16:30
Co-Authored-By: Leo Lamprecht <mindrun@icloud.com>
Co-Authored-By: Leo Lamprecht <mindrun@icloud.com>
@AndyBitz AndyBitz requested a review from leo August 7, 2019 14:37
@codecov-io
Copy link

codecov-io commented Aug 7, 2019

Codecov Report

Merging #2722 into canary will increase coverage by 0.11%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff            @@
##           canary   #2722      +/-   ##
=========================================
+ Coverage    8.19%   8.31%   +0.11%     
=========================================
  Files         261     261              
  Lines       10494   10535      +41     
  Branches     1342    1346       +4     
=========================================
+ Hits          860     876      +16     
- Misses       9575    9599      +24     
- Partials       59      60       +1
Impacted Files Coverage Δ
src/commands/deploy/index.js 0% <0%> (ø) ⬆️
src/util/prefer-v2-deployment.ts 61.36% <60%> (-8.09%) ⬇️
src/util/dev/router.ts 75.71% <0%> (-4.59%) ⬇️
src/util/output/create-output.ts 27.08% <0%> (-2.47%) ⬇️
src/util/get-files.ts 86.26% <0%> (-0.82%) ⬇️
src/util/dev/builder.ts 12.1% <0%> (-0.27%) ⬇️
src/util/dev/server.ts 12.27% <0%> (+0.22%) ⬆️
src/util/dev/builder-cache.ts 39.69% <0%> (+0.43%) ⬆️
src/util/dev/yarn-installer.ts 38.09% <0%> (+0.8%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc72ecb...1330e5c. Read the comment docs.

@AndyBitz AndyBitz merged commit 331b6e0 into canary Aug 7, 2019
@AndyBitz AndyBitz deleted the use-project-for-platform-detection branch August 7, 2019 15:31
AndyBitz added a commit that referenced this pull request Aug 7, 2019
* [now deploy] Use the project when checking the platform version

* Update src/util/prefer-v2-deployment.ts

Co-Authored-By: Leo Lamprecht <mindrun@icloud.com>

* Update src/util/prefer-v2-deployment.ts

Co-Authored-By: Leo Lamprecht <mindrun@icloud.com>

* Adjust message

* Fallback for local config
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants