Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrupt data stream due to HTTP/2 (suspected) #110

Closed
pqvst opened this issue Oct 30, 2016 · 1 comment
Closed

Corrupt data stream due to HTTP/2 (suspected) #110

pqvst opened this issue Oct 30, 2016 · 1 comment

Comments

@pqvst
Copy link

pqvst commented Oct 30, 2016

After quite a few hours of investigation I suspect that multipart/form-data data streams become corrupt (garbled) due to HTTP/2. If I try to a upload a file when using HTTP/2 the first couple of bytes become garbled. If I disable HTTP/2 (chrome --disable-http2) then I am unable to reproduce the issue. I have only been able to reproduce the issue with one specific file on some computers. Not reproducable on all computers that I've tested with.

See linked GitHub project for a minimal test project with detailed investigation observations.
https://github.com/pqvst/form-test

If the culprit is indeed the HTTP/2 stack in now then I would say that this is a pretty critical issue since it means that file uploads aren't guaranteed to work. Perhaps there are other scenarios as well?

@jamo
Copy link
Contributor

jamo commented Jan 2, 2017

Closing this now.
The issue was fixed and confirmed fixed in early december. (and I just forgot to update the issue)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants