-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Offical builder for .net core? #2831
Comments
I would love to help. I've already reached out to Nathan on twitter https://twitter.com/solrevdev/status/1105418843084808192 Also, I had a couple of PR's accepted a while ago creating the hello world now-examples docker version https://github.com/zeit/now-examples/pull/41/commits/495670026bc2930fa32d762dd4093e6286b0f39d and https://github.com/zeit/now-examples/pull/83/commits/6b59bbaccf16a2e1967f7ebf6d24e792fbcc5a03 I am currently reading the docs. Conceptually I am not sure if I need the builder to be written to download and install the dotnetcore framework. I don't think so as dotentcore2.1 is a supported lambda runtime enum. Or do I take the .csproj and supporting files and run If there was a Java example that would be a great starting off point also as they are more similar than say a PHP/Node/Python/Bash builder example as they don't have binaries. |
https://aws.amazon.com/about-aws/whats-new/2018/06/lambda-supports-dotnetcore-twopointone/ Seems like it is? |
Yes I know. It even says so here That’s why I didn’t think I “would need the builder to be written to download and install the dotnetcore framework.....As dotnetcore2.1 is a supported lambda runtime enum” I am still unsure if the builder I need to code itself needs to install the dotnetcore runtime or not. For some reason I could understand the old docker way of deploying over this new wrapper over aws/azure/gcd serverless function way. |
@solrevdev to build dotnet program from source code, you will need dotnet-sdk, which is a superset of dotnet-runtime. However, I did some investigation but found it's almost impossible to install dotnet-sdk in now lambda environment, I have proposed several workarounds https://github.com/zeit/now-builders/issues/826 |
I forgot to post this but after some gentle hassling over on twitter I got @josemnbcamacho to push his working aspnetcore lambda now project up to GitHub. He has a builder over on npm and has an example project on GitHub Amazing bit of work. I was thinking in the right direction but would have never in a million years figured it out I don't think. I think I will try and let some guys from Zeit ( @timothyis ) know about it because it seems a big thing. Anyways, Enjoy |
Is that builder open source? Perhaps we could name it as the Community Builder in our documentation or even consider merging it in here as an Official Builder. |
Hey @styfle , I just open sourced the builder the other day. You can find the builder here: And the sample app here: This was made as a proof of concept. It depends on a hacked gateway layer that AWS uses for their ASP.NET on Lambda, in order to properly work with now. |
Can you elaborate more on how this hack works? It looks like the binaries are downloaded directly from windows.net so it seems official. I would think this method could work with |
AWS Lambda team created this cool feature that lets you package an entire
ASP.NET Core 2.1 application inside a .NET Core 2.1 runtime lambda
function. The problem is that it is not fully compatible with Zeit Now,
probably because the Middleware Now uses is manipulating HTTP requests (not
sure).
https://github.com/aws/aws-lambda-dotnet/tree/master/Libraries/src/Amazon.Lambda.AspNetCoreServer
To fix this problem I had to modify the Amazon Gateway a little, mostly to
correctly map HTTP headers. Those changes are available on my sample app
repo.
|
Thank you for creating this issue! Please note that – in order for us to be able to handle each feature request with care – we have to consume all of them through a unified pipeline that makes it easier for us to prioritize, track and progress on the features our user base is interested in. In turn, the Issues tab on this repository is best only be used for reporting bugs, which we can immediately act on. For well-explained feature requests (like the one you just posted), please contact us at support@zeit.co, so that we can consider adding it to our roadmap. |
Hey guys,
Any plan to support .net core ?
Thanks
The text was updated successfully, but these errors were encountered: