Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offical builder for .net core? #2831

Closed
darting opened this issue Feb 26, 2019 · 10 comments
Closed

Offical builder for .net core? #2831

darting opened this issue Feb 26, 2019 · 10 comments
Labels
triaged: feature request Issue or PR has been reviewed by a maintainer and work is being tracked

Comments

@darting
Copy link

darting commented Feb 26, 2019

Hey guys,

Any plan to support .net core ?

Thanks

@solrevdev
Copy link

I would love to help.

I've already reached out to Nathan on twitter https://twitter.com/solrevdev/status/1105418843084808192

Also, I had a couple of PR's accepted a while ago creating the hello world now-examples docker version https://github.com/zeit/now-examples/pull/41/commits/495670026bc2930fa32d762dd4093e6286b0f39d and https://github.com/zeit/now-examples/pull/83/commits/6b59bbaccf16a2e1967f7ebf6d24e792fbcc5a03

I am currently reading the docs.

Conceptually I am not sure if I need the builder to be written to download and install the dotnetcore framework.

I don't think so as dotentcore2.1 is a supported lambda runtime enum.

Or do I take the .csproj and supporting files and run dotnet publish on them on the now v2 platform and then wave hands do magic via createLambda or do I point createLambda to a pre-built binary?

If there was a Java example that would be a great starting off point also as they are more similar than say a PHP/Node/Python/Bash builder example as they don't have binaries.

@marcosnils
Copy link

I don't think so as dotentcore2.1 is a supported lambda runtime enum.

https://aws.amazon.com/about-aws/whats-new/2018/06/lambda-supports-dotnetcore-twopointone/

Seems like it is?

@solrevdev
Copy link

Yes I know. It even says so here

That’s why I didn’t think I “would need the builder to be written to download and install the dotnetcore framework.....As dotnetcore2.1 is a supported lambda runtime enum”

I am still unsure if the builder I need to code itself needs to install the dotnetcore runtime or not.

For some reason I could understand the old docker way of deploying over this new wrapper over aws/azure/gcd serverless function way.

@hanabi1224
Copy link

@solrevdev to build dotnet program from source code, you will need dotnet-sdk, which is a superset of dotnet-runtime. However, I did some investigation but found it's almost impossible to install dotnet-sdk in now lambda environment, I have proposed several workarounds https://github.com/zeit/now-builders/issues/826

@solrevdev
Copy link

solrevdev commented Jul 26, 2019

I forgot to post this but after some gentle hassling over on twitter I got @josemnbcamacho to push his working aspnetcore lambda now project up to GitHub.

He has a builder over on npm and has an example project on GitHub

Amazing bit of work. I was thinking in the right direction but would have never in a million years figured it out I don't think.

I think I will try and let some guys from Zeit ( @timothyis ) know about it because it seems a big thing.

Anyways, Enjoy

@styfle
Copy link
Member

styfle commented Jul 30, 2019

Is that builder open source?

Perhaps we could name it as the Community Builder in our documentation or even consider merging it in here as an Official Builder.

@josemnbcamacho
Copy link

Hey @styfle , I just open sourced the builder the other day.

You can find the builder here:
https://github.com/josemnbcamacho/now-builders/tree/canary/packages/now-dotnet-aws-lambda-bin

And the sample app here:
https://github.com/josemnbcamacho/aspnet-lambda-now

This was made as a proof of concept. It depends on a hacked gateway layer that AWS uses for their ASP.NET on Lambda, in order to properly work with now.

@styfle
Copy link
Member

styfle commented Aug 2, 2019

It depends on a hacked gateway layer that AWS uses for their ASP.NET on Lambda

Hi @josemnbcamacho

Can you elaborate more on how this hack works?

It looks like the binaries are downloaded directly from windows.net so it seems official.

I would think this method could work with now dev since there are likely binaries for macOS and Windows too.

@josemnbcamacho
Copy link

josemnbcamacho commented Aug 3, 2019 via email

@TooTallNate TooTallNate transferred this issue from another repository Aug 23, 2019
@TooTallNate TooTallNate added the triaged: feature request Issue or PR has been reviewed by a maintainer and work is being tracked label Aug 23, 2019
@leo
Copy link
Contributor

leo commented Dec 27, 2019

Thank you for creating this issue!

Please note that – in order for us to be able to handle each feature request with care – we have to consume all of them through a unified pipeline that makes it easier for us to prioritize, track and progress on the features our user base is interested in.

In turn, the Issues tab on this repository is best only be used for reporting bugs, which we can immediately act on.

For well-explained feature requests (like the one you just posted), please contact us at support@zeit.co, so that we can consider adding it to our roadmap.

@leo leo closed this as completed Dec 27, 2019
@styfle styfle mentioned this issue Apr 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triaged: feature request Issue or PR has been reviewed by a maintainer and work is being tracked
Projects
None yet
Development

No branches or pull requests

8 participants