Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[now-cli] Add tests for alias rules #3003

Merged
merged 1 commit into from Sep 11, 2019
Merged

Conversation

AndyBitz
Copy link
Contributor

@AndyBitz AndyBitz commented Sep 11, 2019

Add integration tests for alias -r rules.json

@codecov-io
Copy link

Codecov Report

Merging #3003 into canary will decrease coverage by 1.3%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           canary    #3003      +/-   ##
==========================================
- Coverage   13.27%   11.96%   -1.31%     
==========================================
  Files         268      268              
  Lines       10329    10180     -149     
  Branches     1223     1295      +72     
==========================================
- Hits         1371     1218     -153     
+ Misses       8896     8870      -26     
- Partials       62       92      +30
Impacted Files Coverage Δ
src/util/dev/server.ts 61.21% <0%> (-5.69%) ⬇️
src/util/dev/yarn-installer.ts 85.71% <0%> (-5.03%) ⬇️
src/util/dev/builder.ts 73.07% <0%> (-4.35%) ⬇️
src/util/dev/router.ts 78.57% <0%> (-4.13%) ⬇️
src/util/dev/builder-cache.ts 77.27% <0%> (-3.48%) ⬇️
src/util/metrics.ts 68.18% <0%> (-2.41%) ⬇️
src/util/projects/get-project-by-id-or-name.ts 28.57% <0%> (+3.57%) ⬆️
src/util/prefer-v2-deployment.ts 61.9% <0%> (+5.65%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c944706...ad8bb97. Read the comment docs.

@TooTallNate
Copy link
Member

Adding new tests reduces code coverage by 1.3%. Go home @codecov-io, you're drunk 😆

@kodiakhq kodiakhq bot merged commit 64356ba into canary Sep 11, 2019
@kodiakhq kodiakhq bot deleted the now-cli/fix-alias-rules branch September 11, 2019 23:32
styfle pushed a commit that referenced this pull request Sep 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants