Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[now-build-utils] Allow a null fallback in Prerender #3144

Merged
merged 1 commit into from Oct 10, 2019

Conversation

Timer
Copy link
Member

@Timer Timer commented Oct 10, 2019

This allows a null fallback to be provided to a Prerender. The use case is a lazily prerendered route (often meaning dynamically rendered).

@codecov-io
Copy link

Codecov Report

Merging #3144 into canary will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           canary   #3144      +/-   ##
=========================================
+ Coverage   13.29%   13.3%   +<.01%     
=========================================
  Files         268     268              
  Lines       10332   10333       +1     
  Branches     1218    1217       -1     
=========================================
+ Hits         1374    1375       +1     
  Misses       8895    8895              
  Partials       63      63
Impacted Files Coverage Δ
src/util/dev/builder.ts 76.1% <0%> (-0.83%) ⬇️
src/commands/dev/index.ts 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4bee64...43e44a2. Read the comment docs.

@kodiakhq kodiakhq bot merged commit c1b2da1 into canary Oct 10, 2019
@kodiakhq kodiakhq bot deleted the update-prerender branch October 10, 2019 05:07
TooTallNate pushed a commit that referenced this pull request Oct 21, 2019
This allows a `null` `fallback` to be provided to a `Prerender`. The use case is a lazily prerendered route (often meaning dynamically rendered).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants