fs.copyFile and snapshot filesystem

[jsonmaur]

Trying to copy a file from the snapshot filesystem to the real filesystem results in the following error:
ENOENT: no such file or directory. Seems to happen in all versions after 4.2.4.

Example code that should work:

fs.copyFile(
  path.resolve(__dirname, 'some_file.json'),
  path.resolve(process.cwd(), 'some_new_file.json')
)

[jsonmaur]

Using ncp as a temporary workaround since it doesn't rely on the fs.copyFile function.

[jdziat]

Another option that works is to use:

const fileBuffer = fs.readFileSync(path.resolve(__dirname, 'some_file.json'))
 
fs.writeFileSync(self.dynLibraryPath, fileBuffer)

[AxelTerizaki]

I can confirm your little trick worked out for me o/

[sqliang]

Trying to copy a file from the snapshot filesystem to the real filesystem results in the following error:
ENOENT: no such file or directory. Seems to happen in all versions after 4.2.4.

Example code that should work:

fs.copyFile(
  path.resolve(__dirname, 'some_file.json'),
  path.resolve(process.cwd(), 'some_new_file.json')
)

Maybe pkg does not kidnap function fs.copyFile. I meet the same issue, and I resolve it by replace copyFile with readFile & writeFile:

// previously:
function copyFile(sourcePath, targetPath) {
    generatedFilePaths.push(targetPath);
    fs.copyFileSync(sourcePath, targetPath);
}
// now:
function copyFile(sourcePath, targetPath) {
    generatedFilePaths.push(targetPath);
    const sourceData = fs.readFileSync(sourcePath, ENCODING);
    fs.writeFileSync(targetPath, sourceData, ENCODING);
}

[paulocoghi]

What can we do when using fs-extra?

I get the same error when calling a fs.copy, but I would not like to manually rewrite it (to be able to apply those workarounds), since there is a lot of things made on fs-extra.

[jdziat]

You need to not use the copy method from the fs-extra package. It must do something with path that pkg intercepts/changes.

[paulocoghi]

It seems to be a regression bug, since it worked fine until 4.2.6.

[jingsam]

This issue is still not solved. Any progress on this issue? @igorklopov

[jingsam]

Hi, @igorklopov thanks for your great work. However, this issue is indeed a pain in our application and still not fixed for two years. Do you have any plans to get this issue to be solved, or suggest some work rounds. Many thanks and wish you a good day.

[medikoo]

We workaround this issue by loading the following patch at beginning of the main module: https://github.com/serverless/serverless/blob/94ff3b22ab13afc60fb4e672520b4db527ee0432/lib/utils/standalone-patch.js

[ryanaltair]

Another option that works is to use:

const fileBuffer = fs.readFileSync(path.resolve(__dirname, 'some_file.json'))
 
fs.writeFileSync(self.dynLibraryPath, fileBuffer)

this work with pkg 4.4.9
with node14

[github-actions]

This issue is stale because it has been open 90 days with no activity. Remove the stale label or comment or this will be closed in 5 days. To ignore this issue entirely you can add the no-stale label

[medikoo]

.

[fbmiranda7]

bump, cant copy file from snapshot

[dukei]

It is really annoying bug. Why is not it getting fixed?

[github-actions]

This issue is stale because it has been open 90 days with no activity. Remove the stale label or comment or this will be closed in 5 days. To ignore this issue entirely you can add the no-stale label

[jingsam]

bump

[github-actions]

This issue is stale because it has been open 90 days with no activity. Remove the stale label or comment or this will be closed in 5 days. To ignore this issue entirely you can add the no-stale label

[paulocoghi]

.

[robertsLando]

Hi everyone, I use pkg like you for my projects and when I find a bug I try to fix it my self, fixing this is not so difficult as it just require to add a patch like the one specified by @medikoo in prelude/bootstrap.js.

Please if you use this project help to keep it maintained by contributing to it.

Thanks

[robertsLando]

PR ready to fix this

[jdziat]

@robertsLando I like it, i think the only thing is that it may lead people to not understand context when working with this package. If they inadvertently forget to include a file in the snapshot and it loads a file from the filesystem instead it could cause some issues or in a worst case scenario a vulnerability. I think that's why this hasn't been patched/implemented.

[robertsLando]

@jdziat IMO the patch should be integrated to bootstrap as lot users are having this issue

[jdziat]

@robertsLando Not disagreeing but you may want to make it possible to turn this off via a flag.

[yunylz]

bump