Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

titleOnly option is being ignored? #70

Closed
coleHafner opened this issue Sep 15, 2019 · 12 comments
Closed

titleOnly option is being ignored? #70

coleHafner opened this issue Sep 15, 2019 · 12 comments

Comments

@coleHafner
Copy link

I have a PR with an invalid PR title and the titleOnly: true option in my .github/semantic.yml file. I still get the status "ready to be merged or rebased". It doesn't seem to matter what I do, this will always be the status. The PR does have many commits that meet the conventional commit standard, but those should be ignored per the titleOnly option, right?

Screen Shot 2019-09-15 at 2 20 39 PM

Config file:

Screen Shot 2019-09-15 at 2 24 10 PM

This repo is a private one within an org, so I'm not sure if that has anything to do with it. I know it has been an issue with other apps I've tried.

@coleHafner
Copy link
Author

This is still an issue, but I found a different solution. I'm closing it for now.

@zeke
Copy link
Owner

zeke commented Sep 17, 2019

Hi. What was your different solution?

@zeke zeke reopened this Sep 17, 2019
@zeke
Copy link
Owner

zeke commented Sep 17, 2019

Re-opening this so we can fix it, regardless of the workaround you found.

@coleHafner
Copy link
Author

@zeke Yours is the third app I've tried to find a solution, but none of them seem to work as advertised. I suspect it has something to do with our private repo within our organization.

I created an app that meets my requirements (mostly out of curiosity of how to create a GitHub App). It seems to be working fine for our team.

@zeke
Copy link
Owner

zeke commented Sep 17, 2019

Thanks for the info.

titleOnly support was added in #30. Hey @guyfedwards are you using this feature successfully?

@guyfedwards
Copy link
Contributor

guyfedwards commented Sep 18, 2019 via email

@zeke
Copy link
Owner

zeke commented Sep 18, 2019

@guyfedwards is your repo public or private?

@guyfedwards
Copy link
Contributor

guyfedwards commented Sep 18, 2019

Open source https://github.com/guyfedwards/emojo. Not much activity on it for a while but you can see some failed PRs

GitHub
Automatically resize emoji and upload from slack. Contribute to guyfedwards/emojo development by creating an account on GitHub.

@mrchief
Copy link

mrchief commented Aug 10, 2020

Came here to report the same thing. Can someone pin the solution/workaround?

@jayithiel
Copy link

titleOnly is being ignored for me as well. It also checks the commit if there is only 1 commit

@don-hover
Copy link

@zeke
Please see:
#105 (comment)

@zeke
Copy link
Owner

zeke commented Feb 24, 2022

This issue is old and inactive so I'm going to close it. If anyone is still affected by this, let me know and I'll re-open it.

@zeke zeke closed this as completed Feb 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants