Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only apply to some subpaths of the repository #89

Closed
felixfbecker opened this issue Apr 21, 2020 · 4 comments
Closed

Only apply to some subpaths of the repository #89

felixfbecker opened this issue Apr 21, 2020 · 4 comments

Comments

@felixfbecker
Copy link

In a monorepo, I want to enforce the semantic convention for only part of the repository (specific directories).
Would it be possible to have an option for that in the YAML?

@zeke
Copy link
Owner

zeke commented Apr 21, 2020

I can see how that would be useful, but it seems like it could add a lot of complexity to this app.

I've been thinking it would be good to rewrite this app as a GitHub Action. Your issue prompted me to open a new issue about that: #90

@felixfbecker
Copy link
Author

Often GitHub apps allow you to configure them through a YAML file that's checked into the repo, e.g. https://github.com/wei/pull
I don't have a good idea of what this entails, but would it really add that much complexity? Without this it makes the app not easy to adapt in a monorepo :/

@zeke
Copy link
Owner

zeke commented Jul 23, 2020

The app currently looks at commits, and commit messages. It doesn't analyze file changes. So yes, without digging too deeply, I think it would be a nontrivial change to make. That said, if you are eager to see this supported, I would welcome a pull request that implements this, with tests, and without breaking any existing functionality.

@zeke
Copy link
Owner

zeke commented Feb 24, 2022

This issue is old and inactive so I'm going to close it. If anyone is still affected by this, let me know and I'll re-open it.

@zeke zeke closed this as completed Feb 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants