Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added in TableView... conflict scrollview with rate pan gesture #5

Closed
valentinjahanmanesh opened this issue Sep 11, 2017 · 6 comments
Closed

Comments

@valentinjahanmanesh
Copy link

hi, i use it in a tableview cell, do you have any suggestion about handling pan gesture ... how can i handle tableview vertical scrollview and emoji rate pan gesture?

@zekunyan
Copy link
Owner

Use the gesture delegate i think

@crspybits
Copy link
Contributor

After struggling with @FarshadJahanmanesh's issue for a few hours, I changed my fork of your very nice Cocoapod to use pan gestures. See https://github.com/crspybits/TTGEmojiRate.git
It seems to work just the same, but also works with scroll views-- or in my case a table view. Are you open to a PR to merge this in?

@zekunyan
Copy link
Owner

zekunyan commented Oct 8, 2017

@crspybits You can open a PR and i will check this ~ :)

@crspybits
Copy link
Contributor

@zekunyan I have just opened a PR :).

@crspybits
Copy link
Contributor

Many Thanks @zekunyan!!! I hadn't updated the pod spec with a new version... And probably you'll want to make a new tag/release-- 0.3.0 ?

@zekunyan
Copy link
Owner

zekunyan commented Oct 9, 2017

@crspybits It's done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants