Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Excludes no longer work with sky/surface/depths selection #74

Closed
elduende05 opened this issue Jul 8, 2023 · 4 comments
Closed

Excludes no longer work with sky/surface/depths selection #74

elduende05 opened this issue Jul 8, 2023 · 4 comments
Labels
bug Something isn't working

Comments

@elduende05
Copy link

Searching for any query with results (e.g. GoronGuidePost) on the sky/surface/depths map will add an empty exclude if you click "hide" (or import an exported query). You have to manually switch to MainField etc. to do exclusions now, which effectively killed importing exclude sets.

@leoetlino leoetlino added the bug Something isn't working label Jul 8, 2023
@savage13
Copy link
Contributor

savage13 commented Jul 9, 2023

This looks to be an issue with the radar-totk backend and the API endpoint
/objids/{map_type}/{map_name}?q=query
and not handling the MainAndMinusField properly.

@leoetlino
Copy link
Member

should be fixed by zeldamods/radar-totk@e6f5fbd

@savage13
Copy link
Contributor

savage13 commented Jul 9, 2023

-    WHERE map_type = ${mapTypeQuery} ${mapNameQuery}
+    WHERE ${mapTypeQuery} ${mapNameQuery}

@leoetlino
Copy link
Member

oh good catch, let me fix that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants