Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need server-side duplicate detection (client crashes with "unackedClientOps is empty") #27

Open
GoogleCodeExporter opened this issue Dec 30, 2015 · 2 comments

Comments

@GoogleCodeExporter
Copy link

The client sometimes crashes with "unackedClientOps is empty".

The logs show this:
com.google.walkabout.walkaround.server.servlet.ClientExceptionHandler 
handleData: [client:1312417505540] Class$S650: TQ{ 11
 s:[]
 exp: 0
 u:[]
 q:[document op: Buffered@35f[__1; x< blip { i="b+Faaaaaaa", v="517" }; x>; __5; ] on blip m/read by ohler@google.com at Wed Aug 03 17:25:04 GMT-700 2011 version null isWorthy true, document op: Buffered@360[__1; << blip { i="b+Faaaaaaa", v="527" }; >>; __5; ] on blip m/read by ohler@google.com at Wed Aug 03 17:25:04 GMT-700 2011 version null isWorthy true]
}: unackedClientOps is empty; resultingRevision=12


Dan and I discussed how to solve this a while ago.  We should add logic to the 
server to detect when it's transforming a client op against another client op 
_from the same client session_.  This situation indicates that the client has 
sent an op twice.  To keep the CC protocol simple, the server should reject the 
client's submit and ask the client to retransform, to cause the client-side 
duplicate detection to kick in and drop the duplicate op.

Original issue reported on code.google.com by oh...@google.com on 15 Dec 2011 at 5:03

@GoogleCodeExporter
Copy link
Author

Forgot to mention that we've seen this problem only very, very rarely, and know 
of no specific recipe to reproduce.  But since it's clear that there's a bug, 
and it's clear how to fix it, we don't need to look for a way to reproduce.

Original comment by oh...@google.com on 15 Dec 2011 at 7:29

  • Added labels: Priority-Low
  • Removed labels: Priority-Medium

@GoogleCodeExporter
Copy link
Author

Original comment by oh...@google.com on 4 Jan 2012 at 7:39

  • Added labels: Component-Slob

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant