Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pane frames can get confused, if disabled and enabled. #690

Closed
a-kenji opened this issue Sep 3, 2021 · 3 comments · Fixed by #697
Closed

Pane frames can get confused, if disabled and enabled. #690

a-kenji opened this issue Sep 3, 2021 · 3 comments · Fixed by #697
Labels
bug Something isn't working

Comments

@a-kenji
Copy link
Contributor

a-kenji commented Sep 3, 2021

If a bordless pane loses focus, a pane frame gets drawn, if pane frames generally are enabled.

Basic information
zellij --version: 0.17.0

Further information
Reproduction:

  • Start zellij --layout-path [TEMPLATE] with the following layout template:
---
template:
  direction: Horizontal
  parts:
    - direction: Vertical
      borderless: true
      split_size:
        Fixed: 1
      run:
        plugin: tab-bar
    - direction: Vertical
      borderless: true
    - direction: Vertical
      borderless: true
      split_size:
        Fixed: 2
      run:
        plugin: status-bar

Gif:
borderless

@imsnif
Copy link
Member

imsnif commented Sep 6, 2021

@a-kenji - I also fixed this in main :) could you please confirm?

@a-kenji
Copy link
Contributor Author

a-kenji commented Sep 6, 2021

@imsnif This is much better now and itself it is fixed,
but I think both of the issues you fixed together still have an interesting interaction:
image

the layout used here is:

---
template:
  direction: Horizontal
  parts:
    - direction: Vertical # part 1
      borderless: true
    - direction: Vertical # part 2
      borderless: true
      split_size:
        Fixed: 1
      run:
        plugin: tab-bar

@a-kenji
Copy link
Contributor Author

a-kenji commented Sep 6, 2021

@imsnif
Nvm, that is just a problem on kitty for me atm, it doesn't seem to be the interaction together.
So this issue is fixed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants