Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to name tabs from the config file #706

Closed
stratosgear opened this issue Sep 10, 2021 · 7 comments · Fixed by #715
Closed

Ability to name tabs from the config file #706

stratosgear opened this issue Sep 10, 2021 · 7 comments · Fixed by #715
Labels
ease of use Issues where zellij has clunky or difficult to use behaviours help wanted Extra attention is needed layout issues related to the layout system

Comments

@stratosgear
Copy link

After looking around (and consulting in the discord channel) it seems there is no way to name your tabs from the config file (you can only name them manually, from a running instance).

I think there ought to be a way to do that from the config file, too!

@imsnif imsnif added help wanted Extra attention is needed ease of use Issues where zellij has clunky or difficult to use behaviours labels Sep 10, 2021
@a-kenji a-kenji added the layout issues related to the layout system label Sep 10, 2021
@a-kenji
Copy link
Contributor

a-kenji commented Sep 10, 2021

Thank you for taking the time writing down this issue.

For anyone that wants to pick this up:
I think it would only make sense to have them be named in the layout file, as opposed to the config file for now.

@stratosgear
Copy link
Author

Yes, I meant the layout file (sorry for messing up the terminology)

@tw4452852
Copy link
Contributor

I can help on this

@a-kenji
Copy link
Contributor

a-kenji commented Sep 10, 2021

That would be awesome! @tw4452852

@a-kenji
Copy link
Contributor

a-kenji commented Sep 10, 2021

@stratosgear
No problem, this is very valuable!

@prscoelho
Copy link
Contributor

Hey guys, since I recently made a PR for tab-bar, my mind is still fresh on this and I have some questions.

Will control characters be allowed in the tab name from layout file? And can we prevent that easily? Currently an unescaped \n or \t will completely mess up the spacing count and rendering, but I don't know if we care at all, it's deliberate bad input and it doesn't result in a panic, just a bad result from bad input.

And since any kind of characters will be allowed into tab name I guess we should probably change the width count from chars().count() to unicode-width. I can make a PR for that.

@a-kenji
Copy link
Contributor

a-kenji commented Sep 11, 2021

@prscoelho
Thanks for raising these issues!
I am all for the tab width pr.
I am not too sure about the escaping one. Maybe open an issue? At some point templating for configured strings make sense maybe. So we can keep that for collecting ideas.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ease of use Issues where zellij has clunky or difficult to use behaviours help wanted Extra attention is needed layout issues related to the layout system
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants