Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash with only one new match #12

Merged
merged 2 commits into from Oct 5, 2018

Conversation

zenangst
Copy link
Owner

@zenangst zenangst commented Oct 5, 2018

Fix crash when trying to diff two collection where the new one only contains one item.
When this happens the algorithm went out of bounds as it moves the offset around.

@codecov-io
Copy link

Codecov Report

Merging #12 into master will decrease coverage by 0.45%.
The diff coverage is 52.38%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #12      +/-   ##
==========================================
- Coverage   32.52%   32.07%   -0.46%     
==========================================
  Files          13       13              
  Lines         578      583       +5     
==========================================
- Hits          188      187       -1     
- Misses        390      396       +6
Impacted Files Coverage Δ
Source/Shared/Algorithm.swift 90.98% <52.38%> (-4.75%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 775fbf5...c286d97. Read the comment docs.

@zenangst zenangst merged commit 6b6ae8c into master Oct 5, 2018
@zenangst zenangst deleted the fix/crash-with-only-one-new-match-part-deux branch October 5, 2018 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants