Add safe-guard for reloading without a superview #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes crash where the view has yet to get a superview. Instead of running the `performBatchUpdates`, the implementation will now invoke `updateDataSource` and run the completion.
zenangst
force-pushed
the
fix/crash-reloading-without-a-superview
branch
from
257938e
to
62df285
Compare
zenangst
force-pushed
the
fix/crash-reloading-without-a-superview
branch
from
62df285
to
02fa93c
Compare
Use `reloadData` if there is no `superview`
Codecov Report
@@ Coverage Diff @@
## master #23 +/- ##
=========================================
- Coverage 66.8% 63.6% -3.21%
=========================================
Files 9 9
Lines 238 250 +12
=========================================
Hits 159 159
- Misses 79 91 +12
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes crash where the view has yet to get a superview.
Instead of running the
performBatchUpdates, the implementationwill now invoke
reloadDatafollowed bycompletion?()and return early.