Make Algorithm static and optimize diff method #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The diff method has been made static and the implementation has been optimized. Now the for-loop retain their own index, it also iterates of ArraySlices.
Codecov Report
@@ Coverage Diff @@
## master #3 +/- ##
==========================================
- Coverage 69.71% 69.67% -0.05%
==========================================
Files 15 15
Lines 710 709 -1
==========================================
- Hits 495 494 -1
Misses 215 215
Continue to review full report at Codecov.
|
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The diff method has been made static and the implementation has been optimized. Now the for-loop retain their own index, it also iterates over ArraySlices.