-
-
Notifications
You must be signed in to change notification settings - Fork 10
UICollectionView inside FamilyViewController has incorrect behavior. #127
Comments
@superk589 Interesting, I haven’t seen this before. I’ll have a look when life allows, on vacation with the family at the moment. (Pun not intended) |
@superk589 I checked out your demo project, thanks for that by the way, it really helped when debugging ❤. I'm happy to report that there is nothing wrong with your implementation, it just seems like there is a rather random rounding bug going on that needs fixing. I've made a PR to fix this here, I tried your demo with that branch and now everything is fine and dandy. A release is on its way. Thanks for bringing this to my attention 😎 |
This bug reappears in the newest version 0.20.7 |
@superk589 hey mate, I’m gonna investigate this issue as soon as I get to the office. |
Hey @superk589, would you mind trying this branch to see if that doesn't fix the issues you've been seeing: |
The bug above is fixed. Thank you. 😊 |
@superk589 awesome! Keep posting issues when you find them and I’ll do my best to smash them with my giant hammer! 🔨😎 |
|
When a collection view with more than one screen items followed by a new collection view with fewer items, the first collection view will be jumpy. |
@superk589 could you open a new issue for this one so that we can keep track on which PR fixes what issue? :) |
@zenangst OK |
The view hierarchy is
FamilyViewController
--UICollectionView inside a UIViewController
--UICollectionView inside a UIViewController
They are added using
addChild(viewController, view: { $0.collectionView })
Each collectionView has 50 items retrieved from network with content size over the screen height.
The result is that the collectionView does not show all the items when scrolling down.
The demo project is here https://github.com/superk589/FamilyDemo
What's wrong in my implementation?
The text was updated successfully, but these errors were encountered: