Skip to content
This repository has been archived by the owner on Dec 22, 2023. It is now read-only.

Multiple UICollectionViews inside FamilyViewController will be jumpy when scrolling #152

Closed
superk589 opened this issue Sep 12, 2019 · 9 comments · Fixed by #154
Closed
Assignees
Labels
bug Something isn't working

Comments

@superk589
Copy link
Contributor

ezgif-4-8878a7150142
This new issue only occurs on real devices. (The device above is iOS 12.4, iPhone X)
When a collection view with more than one screen items followed by a new collection view with fewer items, the first collection view will be jumpy.
Use demo code here(the newest commit):
https://github.com/superk589/FamilyDemo

@zenangst zenangst self-assigned this Sep 12, 2019
@zenangst
Copy link
Owner

@superk589 I'll investigate this when I get to the office today, thanks for creating the demo, it helps a lot for debugging!

@zenangst
Copy link
Owner

@superk589 hey mate, I need to get ahold of a device to test on to verify this.
However, I did find another issue that I fixed, it could contribute to the behavior that you are seeing.
Would you mind trying this branch?: fix/recursion-bug

@superk589
Copy link
Contributor Author

@zenangst
I've tried fix/recursion-bug, but it doesn't help.
This time it becomes jumpy not only on real devices but also on simulators.

@zenangst
Copy link
Owner

Gonna do some additional work on this, still commuting to work. I’ll keep you posted! ;)

@zenangst
Copy link
Owner

At work now, starting to debug… however I'm not seeing what you are seeing at the moment.

@zenangst
Copy link
Owner

Oh, I was just able to reproduce this… let's smash this bug! 🔨

@zenangst
Copy link
Owner

@superk589 I think I found the issue now, mind trying the fix/rounding-issue-in-layout-algorithm branch?

@superk589
Copy link
Contributor Author

@zenangst
Just tried fix/rounding-issue-in-layout-algorithm, I think it has been fixed.

@zenangst
Copy link
Owner

Very nice, I'll merge it into master and make a new version. Thanks for reporting this and following up!

@zenangst zenangst added the bug Something isn't working label Oct 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants