Add Swift Package Manager support #187
Conversation
|
@zocario Good start mate and thanks for starting to add support for this. |
|
@zenangst Not today but I can have a look for macOS at the end of week :) |
|
No worries, I just check to see why Travis wasn't playing ball. Cheers! |
|
I also forgot to add tests targets, I'll polish this and mention you again ;) |
|
@zenangst I had a second look and fixed macOS compilation when opening swift package.
I'm not really sure to see how this has changed with my modifications to be honest. If you have time to give your opinion on the changes I've started don't hesitate :) |
|
Also to me we shouldn't need to use the xcodeproj anymore, but I'm not sure we can work without it regarding travis CI. I'll need to update the xcodeproj to work with the changes I made I'll update this soon. |
zocario
force-pushed
the
feature/spm
branch
3 times, most recently
from
5baec7d
to
7837fd1
Compare
Codecov Report
@@ Coverage Diff @@
## master #187 +/- ##
==========================================
- Coverage 81.45% 80.16% -1.30%
==========================================
Files 11 11
Lines 836 837 +1
==========================================
- Hits 681 671 -10
- Misses 155 166 +11
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
@zenangst So I succeed to setup Travis by using the demo project as container of the swift package. It is using the local swift package and exposes its schemes to be run by Travis. I don't know if this setup would be fine for you (I think it should work for Carthage and Cocoapods but needs to confirm) but this is how I'm doing currently at work to get CI running with swift packages. The constraint is just that the xcodeproj can't be at the root level with this configuration that's why I've used the demo project. |
|
Looking good, I was actually thinking about removing the project all together and perhaps use |
|
Don't have time to do a full review now but perhaps early next week if again… life allows 😎 |
zocario
force-pushed
the
feature/spm
branch
from
7837fd1
to
fe753d3
Compare
|
@zocario mind fixing up the merge conflicts here? (totally my bad 😶) |
zocario
force-pushed
the
feature/spm
branch
from
fe753d3
to
a0c3a47
Compare
|
@zenangst Done :) |
|
Also I have a test failure on Mac OS but nothing fails locally for me (10.15.7 Travis is 10.15.6), would you mind trying on your side? |
| XCTAssertEqual(padding.right, insets.right) | ||
| XCTAssertEqual(padding.bottom, insets.bottom) | ||
|
|
||
| XCTAssertEqual(container.scrollView.bounds, CGRect(origin: .zero, size: CGSize(width: 500, height: 1000))) |
There was a problem hiding this comment.
I removed this line on master, if you do the same I think your branch should work.
zocario
force-pushed
the
feature/spm
branch
from
f3c0c49
to
f7daf10
Compare
Codecov Report
@@ Coverage Diff @@
## master #187 +/- ##
==========================================
- Coverage 81.45% 80.16% -1.30%
==========================================
Files 11 11
Lines 836 837 +1
==========================================
- Hits 681 671 -10
- Misses 155 166 +11
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
Hey @zocario, I tried this branch and I was unable to install it using CocoaPods.
|
|
I'm curious if we could refactor the |
|
Hey @zenangst I'm sorry I completely missed your last message, I'll take an other look this week-end, big weeks at work at the moment 🙈 |
|
@zocario no worries mate :) |
Create target for shared code between macOS and mobile platforms (iOS & tvOS) named Family-Shared. This target is used by both macOS and mobile target. Family-mobile encapsulate both tvOS and iOS frameworks.
Use demo project for travis to expose package targets. Add Family using local package in example project.
|
@zocario Hmm, I'm still having issues installing this using CocoaPods |
|
@zenangst Looks great! Way better approach that my try :) To be honest I wasn't sure about how to do this in an other way, and I had a lots of things to do at work. I should have thought about pre-conditions! I close the PR ;) |
|
@zocario no worries mate, thanks for all the hard work that you put into this! ❤️ |
Hello I'm trying to give a little help regarding support of Swift Package Manager as I need it in one of my project :)
This is a very simple implementation I just did and allowed me to use Family with SPM recently. I'm not sure if this is good enough but I think it is a good base to start with if it helps.
Changes
This target is used by both macOS and mobile target.