Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tests #46

Merged
merged 6 commits into from Jun 19, 2017
Merged

Fix tests #46

merged 6 commits into from Jun 19, 2017

Conversation

onmyway133
Copy link
Sponsor Collaborator

  • We changed signatures of some APIs, so the tests won't work. Fix it
  • Also, update pods and fix 2 demos
  • There is dominant color extractor test that fails. Maybe @vadymmarkov you can take a look at it?

@mention-bot
Copy link

@onmyway133, thanks for your PR! By analyzing the history of the files in this pull request, we identified @zenangst to be a potential reviewer.

@vadymmarkov
Copy link
Contributor

@onmyway133 Do you mean color(at: function?

@onmyway133 onmyway133 mentioned this pull request Jun 19, 2017
Closed
@onmyway133 onmyway133 merged commit 684a4e0 into master Jun 19, 2017
@onmyway133 onmyway133 deleted the fix/tests branch June 19, 2017 11:37
@onmyway133
Copy link
Sponsor Collaborator Author

@vadymmarkov I mean UIImage.colors function

@vadymmarkov
Copy link
Contributor

Then it's probably @zenangst who implemented that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vadymmarkov vadymmarkov vadymmarkov approved these changes

@zenangst zenangst Awaiting requested review from zenangst

@JohnSundell JohnSundell Awaiting requested review from JohnSundell

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@onmyway133 @mention-bot @vadymmarkov