Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve/injection with xcode10 #45

Merged
merged 3 commits into from Oct 15, 2018
Merged

Conversation

zenangst
Copy link
Owner

  • Adds dirty view controller matching as a fallback if view controller cannot be determined using type checking
  • Remove .bundle from pattern check to see if injection is already loaded.

Fallback to using the class name for matching if the class is a view controller
@codecov-io
Copy link

codecov-io commented Oct 15, 2018

Codecov Report

Merging #45 into master will decrease coverage by 0.28%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #45      +/-   ##
==========================================
- Coverage   27.83%   27.55%   -0.29%     
==========================================
  Files          16       16              
  Lines         388      392       +4     
==========================================
  Hits          108      108              
- Misses        280      284       +4
Impacted Files Coverage Δ
Source/Shared/Injection.swift 28.42% <0%> (-1.25%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98b58ae...69af47d. Read the comment docs.

@zenangst zenangst merged commit a0eb2f3 into master Oct 15, 2018
@zenangst zenangst deleted the improve/injection-with-xcode10 branch October 15, 2018 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants