Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Salemaker: dates do not enable #5415

Closed
torvista opened this issue Nov 24, 2022 · 5 comments
Closed

Salemaker: dates do not enable #5415

torvista opened this issue Nov 24, 2022 · 5 comments

Comments

@torvista
Copy link
Member

  1. If past and future dates are set: sale is disabled and cannot be enabled.
  2. If a past start date is set and end date is empty: sale cannot be enabled
  3. If a past start date is empty, and future end date is set: sale is auto enabled and cannot be disabled
  4. If dates are empty: sale can be enabled/disabled ok.

Looks like 1 and 2 are broken.

@scottcwilson
Copy link
Sponsor Contributor

I saw this today and thought I was going crazy! I wound up just deleting the record and adding it again, and it worked.

Thanks for confirming and documenting.

@scottcwilson
Copy link
Sponsor Contributor

Repro'ed finding 1 on demo data - this is exactly what I was seeing this morning. I wonder if now() can no longer be used to set date type fields?

@scottcwilson
Copy link
Sponsor Contributor

For those who are looking at this, please pull other salemaker fixes in - #5414 and #5421.

@scottcwilson
Copy link
Sponsor Contributor

Note though a behavior of Salemaker that is not well documented: clicking the enable/disable button only works for sales with no start/stop dates; sales with start/stop dates are automatically enabled and disabled based on their date settings.

@scottcwilson
Copy link
Sponsor Contributor

Closing; this behavior is not intuitive but documented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants