Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Products not Displaying #6398

Closed
mprough opened this issue Apr 13, 2024 · 2 comments · Fixed by #6399
Closed

New Products not Displaying #6398

mprough opened this issue Apr 13, 2024 · 2 comments · Fixed by #6399

Comments

@mprough
Copy link

mprough commented Apr 13, 2024

Describe the bug
No new products were displaying anywhere, even though the time setting in New Product Listing - Limited to ... is 0

Upon searching I found

Code:
// $display_limit = zen_get_products_new_timelimit();
$display_limit = zen_get_new_date_range();

Version
ZC 2.0
PHP 8.3
Boot 3.6.4

Switching to the commented out code brings all the new products to their parts (sidebox, centerbox, page, etc)

@scottcwilson
Copy link
Sponsor Contributor

scottcwilson commented Apr 13, 2024

Confirmed.

Seems like after fixing we should also remove zen_get_products_new_timelimit() and all commented out calls to it.

@scottcwilson
Copy link
Sponsor Contributor

Group 2 and 3 Configuration settings are integers, not strings.
So this change:
5a4aaab
introduced those two errors.

After my PR is merged I will do a follow on to remove the old unused code; I'll keep this fix small so people can pull it in if they need it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants