Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: new history icons #159

Merged
merged 3 commits into from
May 14, 2020
Merged

feat: new history icons #159

merged 3 commits into from
May 14, 2020

Conversation

ginnywood
Copy link
Contributor

@ginnywood ginnywood commented May 13, 2020 •
edited

  • BREAKING CHANGE?

Description

Adds the following:

  • 12/history-fill
  • 12/history-stroke
  • 16/history-fill
  • 16/history-stroke

Detail

See deployment link for review.

Checklist

  • 👌 SVG updates are Garden Designer approved (add the
    designer as a reviewer)
  • 🌐 SVG demo is up-to-date (yarn start)
  • ◾ Renders as expected in "dark" mode
  • ⬜ Renders as expected @ 2x scale

@ginnywood ginnywood requested a review from a team as a code owner May 13, 2020 21:47
@ginnywood
Copy link
Contributor Author

@jzempel it looks like this branch hasn’t been deployed. Is that a permissions issue? I am a Garden writer but not a maintainer.

@jzempel
Copy link
Member

jzempel commented May 14, 2020

@ginnywood from what I'm seeing in CircleCI, branches that were started before I added the context fix for Writers aren't getting deployment ❤️. I'm afraid this is one of those. I'll pop on to this branch and trigger a deployment.

You shouldn't have problems in the future. Great to see the PR 💪

@zendesk-garden zendesk-garden temporarily deployed to staging May 14, 2020 00:22 Inactive
@jzempel jzempel requested a review from rossmoody May 14, 2020 00:24
jzempel
jzempel approved these changes May 14, 2020
View reviewed changes
Copy link
Member

@jzempel jzempel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added @rossmoody as a design reviewer as it is preferable not to approve your own PR 😉

@allisonacs allisonacs self-requested a review May 14, 2020 01:07
allisonacs
allisonacs approved these changes May 14, 2020
View reviewed changes
Copy link

@allisonacs allisonacs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for inserting myself but I wanted to approve this! So cool @ginnywood to be opening PRs! Rad. The icons look 👌 too!

@jzempel jzempel merged commit 6e8d81e into master May 14, 2020
@jzempel jzempel deleted the gwood/add-history-icon branch May 14, 2020 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jzempel jzempel jzempel approved these changes

@allisonacs allisonacs allisonacs approved these changes

@austingreendev austingreendev austingreendev approved these changes

@rossmoody rossmoody Awaiting requested review from rossmoody

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ginnywood @jzempel @allisonacs @austingreendev @zendesk-garden