Conversation
@@ -24,7 +24,8 @@ | |||
"guzzle/http" : "3.*", | |||
"guzzle/plugin-mock" : "3.*", | |||
"videlalvaro/php-amqplib" : "2.*", | |||
"predis/predis" : "0.8.*" | |||
"predis/predis" : "0.8.*", | |||
"doctrine/migrations" : "dev-master" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
better use 1.0@dev
other than that minor comment looks good to me. |
c91b94b
to
e75ceee
Compare
@lsmith77 pushed. And seems like the tests are failing on master too due to the same segfault. |
hmm .. I somehow seem to remember having seen similar failures in a different repository as well. |
Looks to be the same segfault as #52 - we need to figure out what test is causing it. |
ah damn. so it wasnt a different repo. can one of you adjust the travis.yaml to run phpunit in verbose mode so that we can see which test is causig this? |
0cab025
to
cdae724
Compare
@lsmith77 pushed the verbose flag. I also skipped 2 tests which were in the area where I saw the segfaults. But there is something really weird, different php versions fail on different tests. |
argh sorry .. we also need |
@glaubinix would be so kind and fix indentations ? |
@Thinkscape are you talking about the 2 lines where I marked the tests as skipped. This PR should not be merged like this. I first need to remove all the debugging again. But I am not sure where we are at with the failing build. |
@Thinkscape yes, but different PHP Versions throw the segfault for different tests. |
Tests seem to run locally, only difference is XDebug. Could that cause it? |
likely .. |
please rebase |
38780fc
to
117d81c
Compare
rebase done |
New check to make sure all migrations are applied if you use doctrine migrations.
I had to use mocks for the tests because otherwise a database connection is required.
Note: the doctrine/migrations library does not really maintain tags this is why I used dev-master as dev dependency.