Skip to content
This repository has been archived by the owner on Jan 31, 2020. It is now read-only.

Check for doctrine migration #55

Merged
merged 1 commit into from Jul 9, 2015

Conversation

glaubinix
Copy link
Contributor

New check to make sure all migrations are applied if you use doctrine migrations.
I had to use mocks for the tests because otherwise a database connection is required.

Note: the doctrine/migrations library does not really maintain tags this is why I used dev-master as dev dependency.

@@ -24,7 +24,8 @@
"guzzle/http" : "3.*",
"guzzle/plugin-mock" : "3.*",
"videlalvaro/php-amqplib" : "2.*",
"predis/predis" : "0.8.*"
"predis/predis" : "0.8.*",
"doctrine/migrations" : "dev-master"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better use 1.0@dev

@lsmith77
Copy link
Contributor

other than that minor comment looks good to me.

@Thinkscape ?

@glaubinix glaubinix force-pushed the t/doctrine-migration branch 4 times, most recently from c91b94b to e75ceee Compare April 17, 2015 18:15
@glaubinix
Copy link
Contributor Author

@lsmith77 pushed.

And seems like the tests are failing on master too due to the same segfault.

@lsmith77
Copy link
Contributor

hmm .. I somehow seem to remember having seen similar failures in a different repository as well.

@kbond
Copy link
Contributor

kbond commented Apr 17, 2015

Looks to be the same segfault as #52 - we need to figure out what test is causing it.

@lsmith77
Copy link
Contributor

ah damn. so it wasnt a different repo. can one of you adjust the travis.yaml to run phpunit in verbose mode so that we can see which test is causig this?

@glaubinix
Copy link
Contributor Author

@lsmith77 pushed the verbose flag. I also skipped 2 tests which were in the area where I saw the segfaults. But there is something really weird, different php versions fail on different tests.

@lsmith77
Copy link
Contributor

argh sorry .. we also need --debug

@Thinkscape
Copy link
Member

@glaubinix would be so kind and fix indentations ?

@glaubinix
Copy link
Contributor Author

@Thinkscape are you talking about the 2 lines where I marked the tests as skipped. This PR should not be merged like this. I first need to remove all the debugging again. But I am not sure where we are at with the failing build.

@Thinkscape
Copy link
Member

@glaubinix
Copy link
Contributor Author

@Thinkscape yes, but different PHP Versions throw the segfault for different tests.

@till
Copy link
Contributor

till commented Jul 8, 2015

Tests seem to run locally, only difference is XDebug. Could that cause it?

@lsmith77
Copy link
Contributor

lsmith77 commented Jul 8, 2015

likely ..

@till
Copy link
Contributor

till commented Jul 8, 2015

@lsmith77 Confirmed in #59 — xdebug causes the failures.

@lsmith77
Copy link
Contributor

lsmith77 commented Jul 9, 2015

please rebase

@glaubinix
Copy link
Contributor Author

rebase done

lsmith77 added a commit that referenced this pull request Jul 9, 2015
@lsmith77 lsmith77 merged commit f303100 into zendframework:master Jul 9, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants