Skip to content
This repository has been archived by the owner on Jan 29, 2020. It is now read-only.

Refactor of Zend\Db\Sql for 3.0.0 #362

Open
ezimuel opened this issue Mar 12, 2019 · 7 comments
Open

Refactor of Zend\Db\Sql for 3.0.0 #362

ezimuel opened this issue Mar 12, 2019 · 7 comments

Comments

@ezimuel
Copy link
Contributor

ezimuel commented Mar 12, 2019

This is a task for refactoring Zend\Db\Sql using the type hints of PHP 7.2. You must work on the 3.0.0 branch.

If you change the API you should report it in the /3.0.0.md file.

Note: it's quite difficult to provide this code refactor without changing other classes. That means you should provide the refactoring without pass all the unit tests. In this phase is only important to have the unit tests running, so we you must focus only on fatal/parse errors.

@ezimuel ezimuel created this issue from a note in Zend-db 3.0.0 (To Do) Mar 12, 2019
@ezimuel ezimuel changed the title Refactor of Zend\Db\Sql Refactor of Zend\Db\Sql for 3.0.0 Mar 12, 2019
@guidofaecke
Copy link

I might take a look at it.

@ezimuel
Copy link
Contributor Author

ezimuel commented Mar 13, 2019

Thanks @guidofaecke, let me know if you need some help!

@arueckauer
Copy link
Contributor

@guidofaecke Do you want any assistance?

@guidofaecke
Copy link

You're more than welcome!

Here is what I got so far -> (https://github.com/guidofaecke/zend-db/tree/3.0.0_SQL_typeHints)
It's not a lot, I know, but I'm busy with some work related projects as well 😃

@arueckauer
Copy link
Contributor

That's alright. Me working on a separate fork is unmanageable and PRs are overkill IMO. Would it be okay, if you grant me contribution access to your repo?

@guidofaecke
Copy link

guidofaecke commented Mar 16, 2019

Done... I think... 😆

@weierophinney
Copy link
Member

This repository has been closed and moved to laminas/laminas-db; a new issue has been opened at laminas/laminas-db#19.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Zend-db 3.0.0
  
To Do
Development

No branches or pull requests

4 participants