Skip to content
This repository has been archived by the owner on Jan 21, 2020. It is now read-only.

In HTML5, the <head> element can be omitted. The zend-developer-tools css requires it. #255

Open
2 tasks done
matiasrooseli opened this issue Jan 1, 2019 · 1 comment
Open
2 tasks done

In HTML5, the <head> element can be omitted. The zend-developer-tools css requires it. #255

matiasrooseli opened this issue Jan 1, 2019 · 1 comment

Comments

@matiasrooseli
Copy link

matiasrooseli commented Jan 1, 2019 •
edited

  • I was not able to find an open or closed issue matching what I'm seeing.
  • This is not a question. (Questions should be asked on chat (Signup here) or our forums.)

Provide a narrative description of what you are trying to accomplish.

Code to reproduce the issue

In HTML5, the <head> element can be omitted. The following code will validate as HTML5:

<!DOCTYPE html>
<html>
<title>Title of the document</title>

<body>
<h1>This is a heading</h1>
<p>This is a paragraph.</p>
</body>

</html>

However, ZendDeveloperTools\Listener->injectToolbar() requires it to work

$injected = preg_replace('/<\/head>/i', $style . "\n</head>", $injected, 1);

Expected results

Styles should be displayed in the html document even if there is no <head> html element when the document is html 5 document.

Actual results

html document does not include zend-developer-tools required css, if <head> element is missing from the layout.
@weierophinney weierophinney mentioned this issue Dec 31, 2019
Closed
2 tasks
@weierophinney
Copy link
Member

This repository has been closed and moved to laminas/laminas-developer-tools; a new issue has been opened at laminas/laminas-developer-tools#1.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@weierophinney @matiasrooseli