Skip to content
This repository has been archived by the owner on Jan 30, 2020. It is now read-only.

Zend/Http/Request::renderRequestLine() does not take query parameters into account #69

Open
GeeH opened this issue Jun 28, 2016 · 1 comment

Comments

@GeeH
Copy link
Contributor

GeeH commented Jun 28, 2016

This issue has been moved from the zendframework repository as part of the bug migration program as outlined here - http://framework.zend.com/blog/2016-04-11-issue-closures.html


Original Issue: https://api.github.com/repos/zendframework/zendframework/issues/7472
User: @afeder
Created On: 2015-04-30T16:03:58Z
Updated At: 2015-11-06T21:33:03Z
Body
The renderRequestLine() function of Zend/Http/Request counterintuitively does not include query parameters set via setQuery() in the request line it returns. Is this intentional or is it something for which a patch would likely be accepted?


Comment

User: @adamlundrigan
Created On: 2015-05-01T13:47:35Z
Updated At: 2015-05-01T13:47:35Z
Body
IMO, this is a bug. Zend\Http\Request::renderRequestLine delegates the building of the URI to Zend\Uri\Uri::toString (unless Zend\Http\Request::$uri is a string, of course), but Zend\Http\Request::setQuery does not pass data through to the Uri object so the two fall out of sync.


@weierophinney
Copy link
Member

This repository has been closed and moved to laminas/laminas-http; a new issue has been opened at laminas/laminas-http#14.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants