Skip to content
This repository has been archived by the owner on Jan 30, 2020. It is now read-only.

A logical bug occurs while splitting header field #40

Open
akmandev opened this issue Nov 5, 2019 · 2 comments
Open

A logical bug occurs while splitting header field #40

akmandev opened this issue Nov 5, 2019 · 2 comments
Labels
bug
Milestone
2.7.3

Comments

@akmandev
Copy link

akmandev commented Nov 5, 2019 •
edited
Loading

According to https://tools.ietf.org/html/rfc5322, the following email address example is completely ok:

"Some Name" <email@address.com>

But when you pass this value to Zend\Mime\Decoder::splitHeaderField(); it returns a wrong value because of a logical bug in the code (Line #181, the condition is not correct for all cases):

Expected results

"Some Name" <email@address.com>

Actual results

"Some Name" <email@address.com

So, in the actual result, the last character is missing.

I would like to create a merge request with valid tests if you think this should be fixed.
@akmandev akmandev changed the title A logical bug happens while splitting header field A logical bug occurs while splitting header field Nov 5, 2019
@michalbundyra
Copy link
Member

@ozanakman sure, please submit PR. Thanks!

@akmandev akmandev mentioned this issue Nov 10, 2019
Open
@michalbundyra michalbundyra added this to the 2.7.3 milestone Nov 10, 2019
This was referenced Dec 31, 2019
Closed
Closed
@weierophinney
Copy link
Member

This repository has been closed and moved to laminas/laminas-mime; a new issue has been opened at laminas/laminas-mime#2.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
2.7.3
Development

No branches or pull requests
3 participants
@weierophinney @akmandev @michalbundyra