This repository has been archived by the owner on Jan 30, 2020. It is now read-only.
Compatibility of legacy SM2 style in PHP 7.2. #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alextech
force-pushed
the
hotfix/PHP_7.2_SM2_compatibility
branch
5 times, most recently
from
40b222a
to
09a9ba2
Compare
No need to dynamically request service name, when its known that Navigation::class is one ultimately being requested in __invoke
weierophinney
force-pushed
the
hotfix/PHP_7.2_SM2_compatibility
branch
from
09a9ba2
to
5004fc5
Compare
|
I've rebased this from current develop, which contains updates for PHP 7.2 compatibility; I'll merge if/when the tests are green. |
weierophinney
added a commit
that referenced
this pull request
Apr 25, 2018
|
Thanks, @alextech! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #69. No need to dynamically request service name, when its known that Navigation::class is one ultimately being requested in __invoke
Test will not run against 7.2 because #59 is against dev, while that branch is probably tested against SM3 making this less relevant. Although, test for general creation ability can be ported to improve coverage.