Skip to content
This repository has been archived by the owner on Jan 31, 2020. It is now read-only.

move NamingStrategy to inside Stategy #14

Closed
samsonasik opened this issue Jul 23, 2015 · 7 comments
Closed

move NamingStrategy to inside Stategy #14

samsonasik opened this issue Jul 23, 2015 · 7 comments
Labels

Comments

@samsonasik
Copy link
Contributor

I think NamingStrategy classes can be moved to inside Strategy to collect the strategies. To avoid bc break, we can made old NamingStrategy classes extends Strategy\NamingStrategy\StrategyName.

Any thoughts?

@gianarb
Copy link
Contributor

gianarb commented Jul 23, 2015

Maybe we can build it for ZF3.. Double class is worse respect a ugly path IMO

@samsonasik
Copy link
Contributor Author

@gianarb Ok, I've created PR #15 for it ;)

@Maks3w
Copy link
Member

Maks3w commented Jul 25, 2015

I don't see where is the relation between Strategy and NamingStrategy more far the repetition of characters in the name.

Both interfaces are independent. StrategyInterface vs NamingStrategyInterface

@Maks3w
Copy link
Member

Maks3w commented Jul 25, 2015

Both subcomponents got different responsabilities.

NamingStrategy receive strings and return strings. This component only want to standarize a name.
StrategyInterface receives any and returns any. This component convert between different types extract from type A to type B and viceversa

@samsonasik
Copy link
Contributor Author

While they have different responsibility, they still "a strategy", thats why it good to be collected to 1 directory.

@Maks3w
Copy link
Member

Maks3w commented Jul 25, 2015

That is like to say all interfaces in the same directory. Components are grouped by semantics not by nature.

@samsonasik
Copy link
Contributor Author

that was different terminology

Warm regards,

Abdul Malik Ikhsan

Pada 25 Jul 2015, pukul 16.39, Maks3w notifications@github.com menulis:

That is like to say all interfaces in the same directory. Components are grouped by semantics not by nature.


Reply to this email directly or view it on GitHub.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants